Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: Source/modules/indexeddb/IDBTransaction.cpp

Issue 686153003: Replace IDBPendingTransactionMonitor with end-of-recursion-scope tasks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add explicit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/indexeddb/IDBTransaction.cpp
diff --git a/Source/modules/indexeddb/IDBTransaction.cpp b/Source/modules/indexeddb/IDBTransaction.cpp
index a3f3ea5cedab85656d93bd8ae26666282b879839..71eaaa13de77a77f28e20f965b72930678f4b174 100644
--- a/Source/modules/indexeddb/IDBTransaction.cpp
+++ b/Source/modules/indexeddb/IDBTransaction.cpp
@@ -59,6 +59,30 @@ IDBTransaction* IDBTransaction::create(ScriptState* scriptState, int64_t id, IDB
return transaction;
}
+namespace {
+
+class DeactivateTransactionTask : public V8PerIsolateData::EndOfScopeTask {
+public:
+ static PassOwnPtr<DeactivateTransactionTask> create(IDBTransaction* transaction)
+ {
+ return adoptPtr(new DeactivateTransactionTask(transaction));
+ }
+
+ void Run() override
+ {
+ m_transaction->setActive(false);
+ m_transaction.clear();
+ }
+
+private:
+ explicit DeactivateTransactionTask(IDBTransaction* transaction)
+ : m_transaction(transaction) { }
+
+ Persistent<IDBTransaction> m_transaction;
+};
+
+} // namespace
+
IDBTransaction::IDBTransaction(ScriptState* scriptState, int64_t id, const Vector<String>& objectStoreNames, WebIDBTransactionMode mode, IDBDatabase* db, IDBOpenDBRequest* openDBRequest, const IDBDatabaseMetadata& previousMetadata)
: ActiveDOMObject(scriptState->executionContext())
, m_id(id)
@@ -77,7 +101,7 @@ IDBTransaction::IDBTransaction(ScriptState* scriptState, int64_t id, const Vecto
}
if (m_state == Active)
- V8PerIsolateData::from(scriptState->isolate())->ensureIDBPendingTransactionMonitor()->addNewTransaction(*this);
+ V8PerIsolateData::from(scriptState->isolate())->addEndOfScopeTask(DeactivateTransactionTask::create(this));
m_database->transactionCreated(this);
}
« no previous file with comments | « Source/modules/indexeddb/IDBPendingTransactionMonitor.cpp ('k') | Source/modules/indexeddb/IDBTransactionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698