Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(448)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: Source/web/tests/data/pageserializer/purple_background.png
Issue
68613003
:
Merges the two different page serializers (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove newline after XML decl
Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
Source/core/dom/Element.h
Source/core/editing/MarkupAccumulator.h
Source/core/page/PageSerializer.h
Source/core/page/PageSerializer.cpp
Source/web/WebPageSerializer.cpp
Source/web/WebPageSerializerImpl.h
Source/web/WebPageSerializerImpl.cpp
Source/web/tests/MHTMLTest.cpp
Source/web/tests/PageSerializerTest.cpp
Source/web/tests/WebFrameTest.cpp
Source/web/tests/WebPageNewSerializerTest.cpp
Source/web/tests/WebPageSerializerTest.cpp
Source/web/tests/data/pageserialization/awesome.png
Source/web/tests/data/pageserialization/beautifull.css
Source/web/tests/data/pageserialization/embed_iframe.html
Source/web/tests/data/pageserialization/object_iframe.html
Source/web/tests/data/pageserialization/simple_iframe.html
Source/web/tests/data/pageserialization/simple_page.html
Source/web/tests/data/pageserialization/top_frame.html
Source/web/tests/data/pageserializer/blank_frames.html
Source/web/tests/data/pageserializer/blue_background.png
Source/web/tests/data/pageserializer/css/css_test_page.html
Source/web/tests/data/pageserializer/css/image.png
Source/web/tests/data/pageserializer/css/import_style_from_link.css
Source/web/tests/data/pageserializer/css/import_styles.css
Source/web/tests/data/pageserializer/css/link_styles.css
Source/web/tests/data/pageserializer/css_test_page.html
Source/web/tests/data/pageserializer/datauri/page_with_data.html
Source/web/tests/data/pageserializer/datauri/page_with_morphing_data.html
Source/web/tests/data/pageserializer/dtd/dtd.html
Source/web/tests/data/pageserializer/dtd/html5.html
Source/web/tests/data/pageserializer/elements/elements.html
Source/web/tests/data/pageserializer/elements/image.png
Source/web/tests/data/pageserializer/elements/style.css
Source/web/tests/data/pageserializer/elements/text.txt
Source/web/tests/data/pageserializer/frames/blank_frames.html
Source/web/tests/data/pageserializer/frames/embed_iframe.html
Source/web/tests/data/pageserializer/frames/image.png
Source/web/tests/data/pageserializer/frames/object_iframe.html
Source/web/tests/data/pageserializer/frames/simple_frames.html
Source/web/tests/data/pageserializer/frames/simple_frames_1.html
Source/web/tests/data/pageserializer/frames/simple_frames_3.html
Source/web/tests/data/pageserializer/frames/simple_frames_top.html
Source/web/tests/data/pageserializer/frames/simple_iframe.html
Source/web/tests/data/pageserializer/frames/top_frame.html
Source/web/tests/data/pageserializer/green_background.png
Source/web/tests/data/pageserializer/green_rectangle.svg
Source/web/tests/data/pageserializer/iframe.html
Source/web/tests/data/pageserializer/iframe2.html
Source/web/tests/data/pageserializer/import_style_from_link.css
Source/web/tests/data/pageserializer/import_styles.css
Source/web/tests/data/pageserializer/input-image/button.png
Source/web/tests/data/pageserializer/input-image/input-image.html
Source/web/tests/data/pageserializer/link_styles.css
Source/web/tests/data/pageserializer/namespace/namespace_element.html
Source/web/tests/data/pageserializer/namespace_element.html
Source/web/tests/data/pageserializer/ol-dot.png
Source/web/tests/data/pageserializer/orange_background.png
Source/web/tests/data/pageserializer/page_with_data.html
Source/web/tests/data/pageserializer/page_with_morphing_data.html
Source/web/tests/data/pageserializer/page_with_svg_image.html
Source/web/tests/data/pageserializer/purple_background.png
Source/web/tests/data/pageserializer/red_background.png
Source/web/tests/data/pageserializer/rewritelinks/image.png
Source/web/tests/data/pageserializer/rewritelinks/rewritelinks_base.html
Source/web/tests/data/pageserializer/rewritelinks/rewritelinks_simple.html
Source/web/tests/data/pageserializer/simple.xhtml
Source/web/tests/data/pageserializer/svg/green_rectangle.svg
Source/web/tests/data/pageserializer/svg/page_with_svg_image.html
Source/web/tests/data/pageserializer/top_frame.html
Source/web/tests/data/pageserializer/ul-dot.png
Source/web/tests/data/pageserializer/xml/simple.xhtml
Source/web/tests/data/pageserializer/xml/xmldecl.xml
Source/web/tests/data/pageserializer/xmldecl/xmldecl.xml
Source/web/tests/data/pageserializer/yellow_background.png
Source/web/web.gypi
public/web/WebPageSerializer.h
public/web/WebPageSerializerClient.h
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« Source/web/tests/data/pageserializer/page_with_svg_image.html
('k') |
Source/web/tests/data/pageserializer/red_background.png »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
« no previous file with comments
|
« Source/web/tests/data/pageserializer/page_with_svg_image.html
('k') |
Source/web/tests/data/pageserializer/red_background.png »
('j') |
no next file with comments »
Issue 68613003: Merges the two different page serializers (Closed)
Created 7 years, 1 month ago by Tiger
Modified 7 years ago
Reviewers: abarth-chromium
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 21
This is Rietveld
408576698
Chromium Code Reviews
Issue 68613003:
Merges the two different page serializers (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
