Expose a static interface to TouchCommon on Android.

Expose a static interface to TouchCommon on Android.

Removes the unnecessary dependency on the passed in test base
for getting the root view for event dispatching.  If views are passed
in, then use their own getRootView to ensure event dispatching takes
place on the expected activity.

Otherwise, this exposes methods that take an explicit activity instead
of relying on the instrumentation test base.

BUG=427031
Committed: https://crrev.com/56bf264834f0274eb99446d4e17656cf66a726f1
Cr-Commit-Position: refs/heads/master@{#301918}

[Ted C, 2014-10-29 17:51:40]

tedchoc@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Ted C, 2014-10-29 17:51:40]

@yfriedman - Here's what I had in mind.

[Yaron, 2014-10-29 18:11:25]

lgtm

https://codereview.chromium.org/686123003/diff/20001/content/public/test/andr...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java
(right):

https://codereview.chromium.org/686123003/diff/20001/content/public/test/andr...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java:24:
private ActivityInstrumentationTestCase2<?> mActivityTestCase;
How about changing the member variable to mActivity now and calling
getActivity() on it in the constructor. You could then add the new c-tor so this
is tee'd up for removal

[Ted C, 2014-10-29 19:51:59]

https://codereview.chromium.org/686123003/diff/20001/content/public/test/andr...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java
(right):

https://codereview.chromium.org/686123003/diff/20001/content/public/test/andr...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java:24:
private ActivityInstrumentationTestCase2<?> mActivityTestCase;
On 2014/10/29 18:11:25, Yaron (on leave) wrote:
> How about changing the member variable to mActivity now and calling
> getActivity() on it in the constructor. You could then add the new c-tor so
this
> is tee'd up for removal

Sadly, getActivity() actually will create the activity when first called (in
ActivityInstrumentationTestCase2), and current usage usually builds this in
setup().

I think I'm going to just try and transition all calls to the static methods and
just delete the non-static-y stuff.

[Ted C, 2014-10-29 19:52:58]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2014-10-29 19:53:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686123003/20001

[commit-bot: I haz the power, 2014-10-29 20:41:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-29 20:42:02]

Patchset 2 (id:??) landed as
https://crrev.com/56bf264834f0274eb99446d4e17656cf66a726f1
Cr-Commit-Position: refs/heads/master@{#301918}