Makefile - Issue 686103006: Remove -Werror from pnacl build, due to default switch error in subzero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile

Issue 686103006: Remove -Werror from pnacl build, due to default switch error in subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Makefile

diff --git a/Makefile b/Makefile

index b8934e46632ce5baa8af47464a4c5f13d270cbaa..fc03ae21b71a5e2f8385927f96bd5a0e2d07fe8b 100644

--- a/Makefile

+++ b/Makefile

@@ -12,7 +12,7 @@ LEVEL := $(SUBZERO_LEVEL)/../..

# Include LLVM common makefile.

include $(LEVEL)/Makefile.common

-CXX.Flags += -std=c++11 -Wextra -Werror -Wno-error=unused-parameter

+CXX.Flags += -std=c++11 -Wextra -Wno-error=unused-parameter

Jim Stichnoth 2014/10/30 18:20:34 Maybe you should remove all the -W flags? E.g., i

Karl 2014/10/30 19:30:57 Removed -W flags, and yes, after the merge, remove

CPP.Defines += -DALLOW_TEXT_ASM=1 -DALLOW_DUMP=1 -DALLOW_LLVM_CL=1 \

-DALLOW_LLVM_IR=1 -DALLOW_LLVM_IR_AS_INPUT=1

« no previous file with comments | « no previous file | no next file » | no next file with comments »