src/heap/heap.cc - Issue 686103004: Break allocations in the code serializer into correct chunk sizes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 686103004: Break allocations in the code serializer into correct chunk sizes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 94c8937d4592c6a1cc93377c18b609daa2e478dc..93e00d2d0b223b18d2b780b21e6c32ae58d3548b 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -939,6 +939,8 @@ bool Heap::ReserveSpace(Reservation* reservations) {

for (auto& chunk : *reservation) {

AllocationResult allocation;

int size = chunk.size;

+ DCHECK_LE(size, MemoryAllocator::PageAreaSize(

+ static_cast<AllocationSpace>(space)));

if (space == NEW_SPACE) {

allocation = new_space()->AllocateRaw(size);

} else {

« no previous file with comments | « no previous file | src/heap/spaces.h » ('j') | no next file with comments »