Break allocations in the code serializer into correct chunk sizes.

Break allocations in the code serializer into correct chunk sizes.

This change has been inspired by Slava Chigrin <vchigrin@yandex-team.ru>; (https://codereview.chromium.org/689663002/)

R=mvstanton@chromium.org, vchigrin@yandex-team.ru

Committed: https://code.google.com/p/v8/source/detail?r=25039

[Yang, 2014-10-30 15:32:44]

yangguo@chromium.org changed reviewers:
+ vchigrin@yandex-team.ru

[Slava Chigrin, 2014-10-30 18:36:15]

On 2014/10/30 15:32:45, Yang wrote:

LGTM  Thank you! Your solution indeed more elegant then mine.

[mvstanton, 2014-10-31 11:20:28]

Right on, LGTM. Couple nits.

https://codereview.chromium.org/686103004/diff/1/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/686103004/diff/1/src/heap/spaces.h#newcode1107
src/heap/spaces.h:1107: static int PageAreaSize(AllocationSpace space) {
How about a DCHECK that space isn't LO_SPACE.

https://codereview.chromium.org/686103004/diff/1/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/686103004/diff/1/src/serialize.cc#newcode1937
src/serialize.cc:1937: // The non-branching GetInt will read up to 3 bytes too
far, so we need
Could you add some variant of this comment to the Pad(); declaration in the
header file?

[Yang, 2014-10-31 14:43:31]

Committed patchset #2 (id:20001) manually as 25039 (presubmit successful).