Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 686093002: Oilpan: fix build after r184578. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
6 years, 1 month ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r184578. R=haraken BUG=425623 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184593

Patch Set 1 #

Patch Set 2 : Provide empty virtual ~WindowFrameObserver, non-Oilpan #

Patch Set 3 : typo #

Patch Set 4 : nested classes cannot use empty-dtor-defn macro #

Patch Set 5 : Fix MSVC non-Oilpan compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M Source/core/frame/LocalDOMWindow.h View 1 2 3 4 2 chunks +12 lines, -4 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 3 4 4 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
sof
Please take a look.
6 years, 1 month ago (2014-10-29 11:59:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686093002/1
6 years, 1 month ago (2014-10-29 12:15:47 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/34164)
6 years, 1 month ago (2014-10-29 12:41:26 UTC) #5
haraken
LGTM, thanks for fixing this.
6 years, 1 month ago (2014-10-29 12:56:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686093002/20001
6 years, 1 month ago (2014-10-29 13:44:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/15335)
6 years, 1 month ago (2014-10-29 13:52:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686093002/40001
6 years, 1 month ago (2014-10-29 14:05:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686093002/60001
6 years, 1 month ago (2014-10-29 14:24:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/24424)
6 years, 1 month ago (2014-10-29 14:41:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686093002/80001
6 years, 1 month ago (2014-10-29 15:31:22 UTC) #19
sof
MSVC name visibility issue wrt OwnedPtrDeleter<> for a local private class addressed; tiresome.
6 years, 1 month ago (2014-10-29 15:42:58 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 16:40:43 UTC) #21
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 184593

Powered by Google App Engine
This is Rietveld 408576698