Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 686063002: EmitCreateIteratorResult loads map from function's context (Closed)

Created:
6 years, 1 month ago by wingo
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Dmitry Lomov (no reviews)
Project:
v8
Visibility:
Public.

Description

EmitCreateIteratorResult loads map from function's context Caching or serialization can cause full-codegen output to be shared between contexts. CreateIteratorResult, however, was doing the wrong thing by creating results with the map that was current when the code was generated. Instead, we should chase pointers to load the right map from the function's context. R=verwaest@chromium.org BUG=v8:3656 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -20 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wingo
6 years, 1 month ago (2014-10-29 10:37:54 UTC) #1
Toon Verwaest
lgtm, thanks for fixing this.
6 years, 1 month ago (2014-10-29 16:02:20 UTC) #2
wingo
Committed patchset #1 (id:1) manually as 24987 (presubmit successful).
6 years, 1 month ago (2014-10-29 16:11:10 UTC) #3
rossberg
Note that this needs backmerging to the 3.28 branch. (Should we do 3.27 as well?)
6 years, 1 month ago (2014-10-29 17:25:04 UTC) #4
rossberg
On 2014/10/29 17:25:04, rossberg wrote: > Note that this needs backmerging to the 3.28 branch. ...
6 years, 1 month ago (2014-10-30 09:53:43 UTC) #5
wingo
On 2014/10/30 09:53:43, rossberg wrote: > On 2014/10/29 17:25:04, rossberg wrote: > > Note that ...
6 years, 1 month ago (2014-10-30 13:49:41 UTC) #6
Yang
On 2014/10/30 13:49:41, wingo wrote: > On 2014/10/30 09:53:43, rossberg wrote: > > On 2014/10/29 ...
6 years, 1 month ago (2014-10-30 13:52:27 UTC) #7
rossberg
6 years, 1 month ago (2014-10-30 14:09:53 UTC) #8
Message was sent while issue was closed.
On 2014/10/30 13:52:27, Yang wrote:
> On 2014/10/30 13:49:41, wingo wrote:
> > On 2014/10/30 09:53:43, rossberg wrote:
> > > On 2014/10/29 17:25:04, rossberg wrote:
> > > > Note that this needs backmerging to the 3.28 branch. (Should we do 3.27
as
> > > > well?)
> > > 
> > > Actually, I meant 3.29 (and 3.28?). Somehow I'm always off by one with
> Chrome
> > > and V8 versions...
> > 
> > I can do both if you like.  Would you like new CLs against the 3.29 and 3.28
> > branches?  Does "git cl dcommit" do the right thing in those cases?
> 
> Let me do that by next monday. We got a set of scripts to do this.

Cool, thanks Yang.

Powered by Google App Engine
This is Rietveld 408576698