Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: net/test/embedded_test_server/embedded_test_server.h

Issue 686053005: Add GetURL variant to EmbeddedTestServer with hostname parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/test/embedded_test_server/embedded_test_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/embedded_test_server/embedded_test_server.h
diff --git a/net/test/embedded_test_server/embedded_test_server.h b/net/test/embedded_test_server/embedded_test_server.h
index 9123a511f234f23e0c3a55088c1dec29cb7dcfee..8217be5c9b1a77b678dd78318d084ed7d08db394 100644
--- a/net/test/embedded_test_server/embedded_test_server.h
+++ b/net/test/embedded_test_server/embedded_test_server.h
@@ -129,6 +129,10 @@ class EmbeddedTestServer : public StreamListenSocket::Delegate {
// http://127.0.0.1:<port>/path?query=foo.
GURL GetURL(const std::string& relative_url) const;
+ // Similar to the above method with the difference that it uses the supplied
+ // |hostname| for the URL instead of 127.0.0.1.
mtomasz 2014/10/30 00:25:29 nit: Could you add a comment, that the hostname sh
nasko 2014/10/30 00:45:11 Done.
+ GURL GetURL(const std::string& hostname, const std::string& relative_url);
mtomasz 2014/10/30 00:25:29 nit: This method should be const.
nasko 2014/10/30 00:45:11 Done.
+
// Returns the port number used by the server.
int port() const { return port_; }
« no previous file with comments | « no previous file | net/test/embedded_test_server/embedded_test_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698