Add GetURL variant to EmbeddedTestServer with hostname parameter.

Add GetURL variant to EmbeddedTestServer with hostname parameter.

When writing tests for cross-process navigation, we need to navigate to different hostnames. Doing this in tests requires lots of boilerplate code, which makes the test code harder to read and unlcear when we have cross-process navigation and when not. Adding this method will allow us to avoid the boilerplate code by putting it in a single method and make tests more readable. As we are ramping up work on out-of-process iframes, such tests will become a lot more common than in the past.

BUG=418236
Committed: https://crrev.com/a40f1b0f139724ca6df8be1ee34ad12b82097fda
Cr-Commit-Position: refs/heads/master@{#302012}

[nasko, 2014-10-29 21:52:57]

nasko@chromium.org changed reviewers:
+ mtomasz@chromium.org

[nasko, 2014-10-29 21:52:57]

Hi Tomasz,
Can you please review this CL for me? We found that the cross-site redirector
I've added in the past is not quite sufficient and creates nasty side-effects in
some test cases. Having a direct URL with the proper hostname will help us solve
this problem.
Thanks in advance!
Nasko

[mtomasz, 2014-10-30 00:25:30]

lgtm with 2 nits

https://codereview.chromium.org/686053005/diff/1/net/test/embedded_test_serve...
File net/test/embedded_test_server/embedded_test_server.h (right):

https://codereview.chromium.org/686053005/diff/1/net/test/embedded_test_serve...
net/test/embedded_test_server/embedded_test_server.h:133: // |hostname| for the
URL instead of 127.0.0.1.
nit: Could you add a comment, that the hostname should be routed to 127.0.0.1?

https://codereview.chromium.org/686053005/diff/1/net/test/embedded_test_serve...
net/test/embedded_test_server/embedded_test_server.h:134: GURL GetURL(const
std::string& hostname, const std::string& relative_url);
nit: This method should be const.

[nasko, 2014-10-30 00:45:11]

https://codereview.chromium.org/686053005/diff/1/net/test/embedded_test_serve...
File net/test/embedded_test_server/embedded_test_server.h (right):

https://codereview.chromium.org/686053005/diff/1/net/test/embedded_test_serve...
net/test/embedded_test_server/embedded_test_server.h:133: // |hostname| for the
URL instead of 127.0.0.1.
On 2014/10/30 00:25:29, mtomasz wrote:
> nit: Could you add a comment, that the hostname should be routed to 127.0.0.1?

Done.

https://codereview.chromium.org/686053005/diff/1/net/test/embedded_test_serve...
net/test/embedded_test_server/embedded_test_server.h:134: GURL GetURL(const
std::string& hostname, const std::string& relative_url);
On 2014/10/30 00:25:29, mtomasz wrote:
> nit: This method should be const.

Done.

[nasko, 2014-10-30 00:45:19]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2014-10-30 00:46:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686053005/20001

[commit-bot: I haz the power, 2014-10-30 01:38:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-30 01:39:21]

Patchset 2 (id:??) landed as
https://crrev.com/a40f1b0f139724ca6df8be1ee34ad12b82097fda
Cr-Commit-Position: refs/heads/master@{#302012}