Delete IBusEngineFactoryService.

Delete IBusEngineFactoryService.

IBusEngineFactoryService is no long necessary.

BUG=317535
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235066

[Hiro Komatsu, 2013-11-11 10:05:32]

This patch depends on:
* https://codereview.chromium.org/67313006/
* https://codereview.chromium.org/68503002/

Satoru, please review this patch as an owner of chromeos/chromeos.gyp.

[Seigo Nonaka, 2013-11-12 03:37:22]

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right):

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:586:
GetCurrentService()->UnsetEngine(this);
Seems no need to call this function?

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.h (right):

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:98: void
OnConnected();
This function does no longer make sense.
Please remove :)

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:101: void
OnDisconnected();
ditto

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:138: bool
is_create_engine_handler_called_;
I'm curious about this flag.

Why do we check the CreateEngineHandler is called or not?
CreateEngineHandler does no longer make sense because each Engine instances
keeps alive during user session. We just switch the activated instance with the
SetGlobalEngine call.
Can we just check |active_| instead of this flag?

[Hiro Komatsu, 2013-11-12 05:01:38]

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right):

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:586:
GetCurrentService()->UnsetEngine(this);
On 2013/11/12 03:37:22, Seigo Nonaka wrote:
> Seems no need to call this function?

I am deleting IBusEngineService in a different patch.  Please let me handle it
in that patch.

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.h (right):

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:98: void
OnConnected();
On 2013/11/12 03:37:22, Seigo Nonaka wrote:
> This function does no longer make sense.
> Please remove :)

Thank you for the information.  Please let me do it  in a different patch, since
it seems to be called by  InputMethodManager so deleting it would not be the
focus of this patch.

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:101: void
OnDisconnected();
On 2013/11/12 03:37:22, Seigo Nonaka wrote:
> ditto

Here too.

https://codereview.chromium.org/68603002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:138: bool
is_create_engine_handler_called_;
On 2013/11/12 03:37:22, Seigo Nonaka wrote:
> I'm curious about this flag.
> 
> Why do we check the CreateEngineHandler is called or not?
> CreateEngineHandler does no longer make sense because each Engine instances
> keeps alive during user session. We just switch the activated instance with
the
> SetGlobalEngine call.
> Can we just check |active_| instead of this flag?

I just focused on the deletion of IBusEngineFactoryService keeping the current
logic as-is.  object_path_ was checked if it was empty or not, so I tried to
keep this logic using a bool variable instead of object_path_.

So please let me change the logic you suggested, after deleting
IBusEngineFactoryService.

[Seigo Nonaka, 2013-11-12 12:29:53]

lgtm

[satorux1, 2013-11-13 14:18:58]

lgtm

[commit-bot: I haz the power, 2013-11-14 01:26:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/komatsu@chromium.org/68603002/80001

[commit-bot: I haz the power, 2013-11-14 02:23:58]

Retried try job too often on mac for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-11-14 03:39:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/komatsu@chromium.org/68603002/80001

[commit-bot: I haz the power, 2013-11-14 06:34:16]

Change committed as 235066