Enable AX TCs related to list-item and update results.

Enable AX TCs related to list-item and update results.

BUG=347865
Committed: https://crrev.com/f4c94e4ff0da29b09ad671f372b799c10d748b8f
Cr-Commit-Position: refs/heads/master@{#304022}

[dmazzoni, 2014-11-03 16:50:11]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2014-11-03 16:50:12]

https://codereview.chromium.org/685993005/diff/1/content/test/data/accessibil...
File
content/test/data/accessibility/contenteditable-descendants-expected-win.txt
(right):

https://codereview.chromium.org/685993005/diff/1/content/test/data/accessibil...
content/test/data/accessibility/contenteditable-descendants-expected-win.txt:18:
ROLE_SYSTEM_LISTITEM name='Editable list item' IA2_STATE_EDITABLE
I'm slightly worried that this could result in double-speaking since the text
appears on this node and also on its static text child. We should test it with a
screen reader. Have you compared what Firefox does here?

[je_julie(Not used), 2014-11-04 03:02:53]

On 2014/11/03 16:50:12, dmazzoni wrote:
>
https://codereview.chromium.org/685993005/diff/1/content/test/data/accessibil...
> File
> content/test/data/accessibility/contenteditable-descendants-expected-win.txt
> (right):
> 
>
https://codereview.chromium.org/685993005/diff/1/content/test/data/accessibil...
>
content/test/data/accessibility/contenteditable-descendants-expected-win.txt:18:
> ROLE_SYSTEM_LISTITEM name='Editable list item' IA2_STATE_EDITABLE
> I'm slightly worried that this could result in double-speaking since the text
> appears on this node and also on its static text child. We should test it with
a
> screen reader. Have you compared what Firefox does here?

Hi Dominic,
Good point. I should have checked it with FF.
I'm on a trip to attend BlinkOn3 now. 
I think I can check it with FF on Windows this weekend. Sorry for delay.
I saw the patch(696133002) to disable TCs was landed.
Should we revert it as well? If then, I can upload revert patch here.
Thanks,

[dmazzoni, 2014-11-06 07:15:40]

No rush, I think it's fine to leave 696133002 landed for a few more days.

- Dominic

On Mon, Nov 3, 2014 at 7:02 PM, <je_julie.kim@samsung.com> wrote:

> Reviewers: dmazzoni,
>
> Message:
> On 2014/11/03 16:50:12, dmazzoni wrote:
>
> https://codereview.chromium.org/685993005/diff/1/content/
> test/data/accessibility/contenteditable-descendants-expected-win.txt
>
>> File
>> content/test/data/accessibility/contenteditable-
>> descendants-expected-win.txt
>> (right):
>>
>
>
> https://codereview.chromium.org/685993005/diff/1/content/
> test/data/accessibility/contenteditable-descendants-
> expected-win.txt#newcode18
>
> content/test/data/accessibility/contenteditable-
> descendants-expected-win.txt:18:
>
>> ROLE_SYSTEM_LISTITEM name='Editable list item' IA2_STATE_EDITABLE
>> I'm slightly worried that this could result in double-speaking since the
>> text
>> appears on this node and also on its static text child. We should test it
>> with
>>
> a
>
>> screen reader. Have you compared what Firefox does here?
>>
>
> Hi Dominic,
> Good point. I should have checked it with FF.
> I'm on a trip to attend BlinkOn3 now.
> I think I can check it with FF on Windows this weekend. Sorry for delay.
> I saw the patch(696133002) to disable TCs was landed.
> Should we revert it as well? If then, I can upload revert patch here.
> Thanks,
>
> Description:
> Update results for TCs related to ListItem
>
> BUG=347865
>
> Please review this at https://codereview.chromium.org/685993005/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+91, -59 lines):
>   M content/test/data/accessibility/aria-list-expected-android.txt
>   M content/test/data/accessibility/aria-list-expected-mac.txt
>   M content/test/data/accessibility/aria-list-expected-win.txt
>   M content/test/data/accessibility/contenteditable-
> descendants-expected-android.txt
>   M content/test/data/accessibility/contenteditable-
> descendants-expected-mac.txt
>   M content/test/data/accessibility/contenteditable-
> descendants-expected-win.txt
>   M content/test/data/accessibility/list-expected-android.txt
>   M content/test/data/accessibility/list-expected-mac.txt
>   M content/test/data/accessibility/list-expected-win.txt
>   M content/test/data/accessibility/list-markers-expected-android.txt
>   M content/test/data/accessibility/list-markers-expected-mac.txt
>   M content/test/data/accessibility/list-markers-expected-win.txt
>   M content/test/data/accessibility/ol-expected-android.txt
>   M content/test/data/accessibility/ol-expected-mac.txt
>   M content/test/data/accessibility/ol-expected-win.txt
>   M content/test/data/accessibility/ul-expected-android.txt
>   M content/test/data/accessibility/ul-expected-mac.txt
>   M content/test/data/accessibility/ul-expected-win.txt
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[je_julie(Not used), 2014-11-12 05:01:53]

Hi Dominic,
I've checked screen readers as I shared on
https://codereview.chromium.org/696953002/.
This patch enables AX TCs disabled due to update code on blink and updates test
results.
PTAL.

On 2014/11/06 07:15:40, dmazzoni wrote:
> No rush, I think it's fine to leave 696133002 landed for a few more days.
> 
> - Dominic

[dmazzoni, 2014-11-12 05:15:51]

lgtm

[dmazzoni, 2014-11-12 05:15:56]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-11-12 05:16:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/685993005/20001

[commit-bot: I haz the power, 2014-11-12 07:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-12 07:07:13]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[je_julie(Not used), 2014-11-13 12:22:01]

The CQ bit was checked by je_julie.kim@samsung.com

[commit-bot: I haz the power, 2014-11-13 12:22:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/685993005/40001

[commit-bot: I haz the power, 2014-11-13 13:17:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-13 13:18:08]

Patchset 3 (id:??) landed as
https://crrev.com/f4c94e4ff0da29b09ad671f372b799c10d748b8f
Cr-Commit-Position: refs/heads/master@{#304022}