Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 685993003: [turbofan] Lower NumberModulus to Uint32Mod if both inputs are Unsigned32. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower NumberModulus to Uint32Mod if both inputs are Unsigned32. TEST=cctest/test-simplified-lowering R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +5 lines, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-10-31 07:56:07 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-10-31 07:57:59 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-10-31 07:58:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698