gpu: Associate all GpuMemoryBuffers with unique IDs.

content/common/child_process_host_impl.cc

Index: content/common/child_process_host_impl.cc
diff --git a/content/common/child_process_host_impl.cc b/content/common/child_process_host_impl.cc
index 67326248870a04b7a582c60df1b990303a4e1b36..fc531437eb146dca770ff6724816c6ee02e7b778 100644
--- a/content/common/child_process_host_impl.cc
+++ b/content/common/child_process_host_impl.cc
@@ -79,6 +79,9 @@ base::FilePath TransformPathForFeature(const base::FilePath& path,
 // Global atomic to generate child process unique IDs.
 base::StaticAtomicSequenceNumber g_unique_id;
 
+// Global atomic to generate gpu memory buffer unique IDs.
+base::StaticAtomicSequenceNumber g_next_gpu_memory_buffer_id;
+
 }  // namespace
 
 namespace content {
@@ -334,6 +337,7 @@ void ChildProcessHostImpl::OnAllocateGpuMemoryBuffer(
   // Note: It is safe to use base::Unretained here as the shared memory
   // implementation of AllocateForChildProcess() calls this synchronously.
   GpuMemoryBufferImplSharedMemory::AllocateForChildProcess(
+      g_next_gpu_memory_buffer_id.GetNext(),

[alexst (slow to review), 2014/11/04 14:24:39]

When do we get into this code? As far as I can tell, if the filter handles all
the messages.

[reveman, 2014/11/04 18:19:39]

This is for non-renderer child processes. The plan is to turn
BrowserGpuMemoryBufferManager into HostGpuMemoryBufferManager so it can be used
here to provide the same type of buffers to non-renderer child processes instead
of this shared memory only implementation that currently lives here.

       gfx::Size(width, height),
       format,
       peer_handle_,
@@ -344,7 +348,7 @@ void ChildProcessHostImpl::OnAllocateGpuMemoryBuffer(
 
 void ChildProcessHostImpl::OnDeletedGpuMemoryBuffer(
     gfx::GpuMemoryBufferType type,
-    const gfx::GpuMemoryBufferId& id,
+    gfx::GpuMemoryBufferId id,
     uint32 sync_point) {
   // Note: Nothing to do here as ownership of shared memory backed
   // GpuMemoryBuffers is passed with IPC.