content/common/gpu/client/gpu_memory_buffer_factory_host.h - Issue 685983005: gpu: Associate all GpuMemoryBuffers with unique IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_factory_host.h

Issue 685983005: gpu: Associate all GpuMemoryBuffers with unique IDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and address feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/gpu_channel_host.cc ('K') | « content/common/gpu/client/gpu_channel_host.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_factory_host.h

diff --git a/content/common/gpu/client/gpu_memory_buffer_factory_host.h b/content/common/gpu/client/gpu_memory_buffer_factory_host.h

index 6d17bfe30e1b9d97f82ec5abd5213558b73ecbd3..827308ed79ef696df2b7e1259b1ed72a3aeae36f 100644

--- a/content/common/gpu/client/gpu_memory_buffer_factory_host.h

+++ b/content/common/gpu/client/gpu_memory_buffer_factory_host.h

@@ -23,12 +23,16 @@ class CONTENT_EXPORT GpuMemoryBufferFactoryHost {

static GpuMemoryBufferFactoryHost* GetInstance();

virtual void CreateGpuMemoryBuffer(

- const gfx::GpuMemoryBufferHandle& handle,

+ gfx::GpuMemoryBufferType type,

+ gfx::GpuMemoryBufferId id,

const gfx::Size& size,

gfx::GpuMemoryBuffer::Format format,

gfx::GpuMemoryBuffer::Usage usage,

+ int client_id,

const CreateGpuMemoryBufferCallback& callback) = 0;

- virtual void DestroyGpuMemoryBuffer(const gfx::GpuMemoryBufferHandle& handle,

+ virtual void DestroyGpuMemoryBuffer(gfx::GpuMemoryBufferType type,

+ gfx::GpuMemoryBufferId id,

+ int client_id,

int32 sync_point) = 0;

protected: