content/browser/gpu/gpu_memory_buffer_factory_host_impl.h - Issue 685983005: gpu: Associate all GpuMemoryBuffers with unique IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_memory_buffer_factory_host_impl.h

Issue 685983005: gpu: Associate all GpuMemoryBuffers with unique IDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and address feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('k') | content/browser/gpu/gpu_memory_buffer_factory_host_impl.cc » ('j') | content/browser/gpu/gpu_memory_buffer_factory_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/gpu_memory_buffer_factory_host_impl.h

diff --git a/content/browser/gpu/gpu_memory_buffer_factory_host_impl.h b/content/browser/gpu/gpu_memory_buffer_factory_host_impl.h

index 0d2029557c93ef7bdb7649e1f9a6a12228fd95e0..6cdf6b726d5e465db4ce0156e2a572932d1a85c0 100644

--- a/content/browser/gpu/gpu_memory_buffer_factory_host_impl.h

+++ b/content/browser/gpu/gpu_memory_buffer_factory_host_impl.h

@@ -19,23 +19,24 @@ class CONTENT_EXPORT GpuMemoryBufferFactoryHostImpl

// Overridden from GpuMemoryBufferFactoryHost:

void CreateGpuMemoryBuffer(

- const gfx::GpuMemoryBufferHandle& handle,

+ gfx::GpuMemoryBufferType type,

+ gfx::GpuMemoryBufferId id,

const gfx::Size& size,

gfx::GpuMemoryBuffer::Format format,

gfx::GpuMemoryBuffer::Usage usage,

+ int client_id,

const CreateGpuMemoryBufferCallback& callback) override;

- void DestroyGpuMemoryBuffer(const gfx::GpuMemoryBufferHandle& handle,

+ void DestroyGpuMemoryBuffer(gfx::GpuMemoryBufferType type,

+ gfx::GpuMemoryBufferId id,

+ int client_id,

int32 sync_point) override;

void set_gpu_host_id(int gpu_host_id) { gpu_host_id_ = gpu_host_id; }

private:

- void CreateGpuMemoryBufferOnIO(const gfx::GpuMemoryBufferHandle& handle,

- const gfx::Size& size,

- gfx::GpuMemoryBuffer::Format format,

- gfx::GpuMemoryBuffer::Usage usage,

- const CreateGpuMemoryBufferCallback& callback);

- void DestroyGpuMemoryBufferOnIO(const gfx::GpuMemoryBufferHandle& handle,

+ void DestroyGpuMemoryBufferOnIO(gfx::GpuMemoryBufferType type,

+ gfx::GpuMemoryBufferId id,

+ int client_id,

int32 sync_point);

void OnGpuMemoryBufferCreated(uint32 request_id,

const gfx::GpuMemoryBufferHandle& handle);