Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/common/gpu/gpu_memory_buffer_factory.h

Issue 685983005: gpu: Associate all GpuMemoryBuffers with unique IDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more ozone build fix Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_channel_manager.cc ('k') | content/common/gpu/gpu_memory_buffer_factory_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_memory_buffer_factory.h
diff --git a/content/common/gpu/gpu_memory_buffer_factory.h b/content/common/gpu/gpu_memory_buffer_factory.h
index 0c06537b3c484588eab1695d728cdd3c8d519102..5dd2203f2680e4bec2d1e945b8fc4e5a6f7fb2fd 100644
--- a/content/common/gpu/gpu_memory_buffer_factory.h
+++ b/content/common/gpu/gpu_memory_buffer_factory.h
@@ -28,18 +28,20 @@ class GpuMemoryBufferFactory {
// Creates a new platform specific factory instance.
static scoped_ptr<GpuMemoryBufferFactory> Create();
- // Creates a GPU memory buffer instance from |handle|. Whether the storage for
- // the buffer is passed with the handle or allocated as part of buffer
- // creation depends on the type. A valid handle is returned on success.
+ // Creates a GPU memory buffer instance of |type|. A valid handle is
+ // returned on success.
virtual gfx::GpuMemoryBufferHandle CreateGpuMemoryBuffer(
- const gfx::GpuMemoryBufferHandle& handle,
+ gfx::GpuMemoryBufferType type,
+ gfx::GpuMemoryBufferId id,
const gfx::Size& size,
gfx::GpuMemoryBuffer::Format format,
- gfx::GpuMemoryBuffer::Usage usage) = 0;
+ gfx::GpuMemoryBuffer::Usage usage,
+ int client_id) = 0;
- // Destroys GPU memory buffer identified by |handle|.
- virtual void DestroyGpuMemoryBuffer(
- const gfx::GpuMemoryBufferHandle& handle) = 0;
+ // Destroys GPU memory buffer identified by |id|.
+ virtual void DestroyGpuMemoryBuffer(gfx::GpuMemoryBufferType type,
+ gfx::GpuMemoryBufferId id,
+ int client_id) = 0;
// Type-checking downcast routine.
virtual gpu::ImageFactory* AsImageFactory() = 0;
« no previous file with comments | « content/common/gpu/gpu_channel_manager.cc ('k') | content/common/gpu/gpu_memory_buffer_factory_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698