gpu: Associate all GpuMemoryBuffers with unique IDs.

content/browser/android/browser_surface_texture_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/browser_surface_texture_manager.h"
 
 #include <android/native_window_jni.h>
 
 #include "base/android/jni_android.h"
 #include "content/browser/android/child_process_launcher_android.h"
@@ skipping 77 matching lines @@
       surface_texture_id, client_id, surface_texture);
 }
 
 void BrowserSurfaceTextureManager::UnregisterSurfaceTexture(
     int surface_texture_id,
     int client_id) {
   content::DestroySurfaceTextureSurface(surface_texture_id, client_id);
 }
 
 gfx::AcceleratedWidget BrowserSurfaceTextureManager::AcquireNativeWidget(
-    int surface_texture_id,
-    int client_id) {
+    int surface_texture_id) {
+  const int kBrowserClientId = 0;

[piman, 2014/11/04 01:07:26]

Why 0, where does it come from?
Can RegisterSurfaceTexture be called with client_id == 0? From where?

If/when Android uses out-of-process gpu, doesn't this need to be
BrowserGpuChannelHostFactory::GetGpuChannelId() ?

[piman, 2014/11/04 01:22:46]

Double-checked: this should be
BrowserGpuChannelHostFactory::instance()->GetGpuChannelId() even for Android
without a GPU process.

[reveman, 2014/11/04 06:20:46]

Thanks. Fixed in latest patch.

   gfx::ScopedJavaSurface surface(
-      content::GetSurfaceTextureSurface(surface_texture_id, client_id));
+      content::GetSurfaceTextureSurface(surface_texture_id, kBrowserClientId));
   if (surface.j_surface().is_null())
     return NULL;
 
   JNIEnv* env = base::android::AttachCurrentThread();
   // Note: This ensures that any local references used by
   // ANativeWindow_fromSurface are released immediately. This is needed as a
   // workaround for https://code.google.com/p/android/issues/detail?id=68174
   base::android::ScopedJavaLocalFrame scoped_local_reference_frame(env);
   ANativeWindow* native_window =
       ANativeWindow_fromSurface(env, surface.j_surface().obj());
@@ skipping 12 matching lines @@
   BrowserThread::PostTask(BrowserThread::UI,
                           FROM_HERE,
                           base::Bind(&SetSurfacePeer,
                                      surface_texture,
                                      render_process_handle,
                                      render_frame_id,
                                      player_id));
 }
 
 }  // namespace content