LayoutTests/fast/events/hit-test-culled_inline.html - Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/hit-test-culled_inline.html

Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style type="text/css">

	3 input, em { cursor: pointer; margin-right: 100px; }

	4 label, span { cursor: pointer; background: transparent; }

	5 </style>

	6 <script src="../../resources/js-test.js"></script>

	7 <div><label id="label" for="checkbox"><input id="checkbox" type="checkbox">Click the empty area on the left</input></label></div>

	8 <div><span id="span"><em id="em">Click the empty area</em><em>in middle</em></sp an></div>

	9 <p id="description"></p>

	10 <div id="console"></div>

	11 <script>

	12 description('Click event should be fired when it occurs within culled inline .');

	13

	14 function hitTest(id) {

	15 var element = document.getElementById(id);

	16 var parent = element.parentElement;

	17 x = element.offsetLeft + element.offsetWidth + 10;

	18 y = element.offsetTop + element.offsetHeight / 2;

	19 parent.addEventListener('click', function(e) {

	20 debug(parent.nodeName + ' that is a parent of ' + element.nodeName + ' is clicked.');
	Rick Byers 2014/11/11 17:19:16 Thanks for the refactor, but now we've lost the ex Thanks for the refactor, but now we've lost the explicit PASS/FAIL result from the test. Someone changing the test output might not fully understand what you expected to happen. Maybe set a 'gotClick' bool here, and add a shouldBeTrue('gotClick') below the mouseUp. shouldBe* requires using globals, so you'll have to re-initialize gotClick to false at the start of each call to hitTest.
	21 e.preventDefault();

	22 });

	23 eventSender.mouseMoveTo(x, y);

	24 eventSender.mouseDown();

	25 eventSender.mouseUp();

	26 }

	27 if (window.eventSender) {

	28 hitTest('checkbox');
	Rick Byers 2014/11/11 17:19:16 you've also lost your test that verifies the check you've also lost your test that verifies the checkbox got clicked. That seems nice to have. You can re-add it here (and even add a shouldBeFalse('checkbox.clicked' above to really verify that it's the hitTest doing the click). Alternately if you only want to test hit test behavior (and not all of click) you can simplify this test by using elementFromPoint instead of eventSender. They use the same hit-test logic under the covers.
	29 hitTest('em');

	30 }

	31 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/hit-test-culled_inline-expected.txt » ('j') | no next file with comments »