LayoutTests/fast/forms/label/label-hit-test-culled_inline.html - Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/label/label-hit-test-culled_inline.html

Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style type="text/css">

	3 input, em { cursor: pointer; margin-right: 100px; }

	4 label, span { cursor: pointer; background: transparent; }

	5 </style>

	6 <script src="../../../resources/js-test.js"></script>

	7 <div><label id="label" for="checkbox"><input id="checkbox" type="checkbox">Click the empty area on the left</input></label></div>

	8 <div><span id="span"><em id="em">Click the empty area</em><em>in middle</em></sp an></div>

	9 <p id="description"></p>

	10 <div id="console"></div>

	11 <script>

	12 description('Click event should be fired when it occurs within culled inline .');

	13

	14 var checkbox = document.getElementById('label');

	15 var span = document.getElementById('span');

	16

	17 var labelClicked = false;

	18 var spanClicked = false;

	19 label.addEventListener('click', function() { labelClicked = true; });
	Rick Byers 2014/11/10 18:40:09 There are two test cases being tested simultaneous There are two test cases being tested simultaneously here. Please refactor the test into a helper function and call it twice with the two different candidate notes. This strengthens the test to, for example, validate that your getting the click on the element you expect when you expect it. This also makes it easy to add more test cases if we find these two aren't sufficiently representative.
	20 span.addEventListener('click', function() { spanClicked = true; });

	21 if (window.eventSender) {

	22 var x = label.offsetLeft + 50;

	23 var y = label.offsetTop + label.offsetHeight / 2;

	24 eventSender.mouseMoveTo(x, y);

	25 eventSender.mouseDown();

	26 eventSender.mouseUp();

	27

	28 var em = document.getElementById('em');

	29 x = em.offsetWidth + 10;

	30 y = em.offsetTop + span.offsetHeight / 2;

	31 eventSender.mouseMoveTo(x, y);

	32 eventSender.mouseDown();

	33 eventSender.mouseUp();

	34 }

	35 shouldBeTrue('labelClicked');

	36 shouldBeTrue('document.getElementById("checkbox").checked');

	37 shouldBeTrue('spanClicked');

	38 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/label/label-hit-test-culled_inline-expected.txt » ('j') | no next file with comments »