Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Side by Side Diff: Source/core/rendering/RenderInline.cpp

Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/InlineFlowBox.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 private: 800 private:
801 bool m_intersected; 801 bool m_intersected;
802 Region& m_region; 802 Region& m_region;
803 const HitTestLocation& m_location; 803 const HitTestLocation& m_location;
804 }; 804 };
805 805
806 } // unnamed namespace 806 } // unnamed namespace
807 807
808 bool RenderInline::hitTestCulledInline(const HitTestRequest& request, HitTestRes ult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accu mulatedOffset) 808 bool RenderInline::hitTestCulledInline(const HitTestRequest& request, HitTestRes ult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accu mulatedOffset)
809 { 809 {
810 ASSERT(result.isRectBasedTest() && !alwaysCreateLineBoxes()); 810 ASSERT(!alwaysCreateLineBoxes());
811 if (!visibleToHitTestRequest(request)) 811 if (!visibleToHitTestRequest(request))
812 return false; 812 return false;
813 813
814 HitTestLocation tmpLocation(locationInContainer, -toLayoutSize(accumulatedOf fset)); 814 HitTestLocation tmpLocation(locationInContainer, -toLayoutSize(accumulatedOf fset));
815 815
816 Region regionResult; 816 Region regionResult;
817 HitTestCulledInlinesGeneratorContext context(regionResult, tmpLocation); 817 HitTestCulledInlinesGeneratorContext context(regionResult, tmpLocation);
818 generateCulledLineBoxRects(context, this); 818 generateCulledLineBoxRects(context, this);
819 819
820 if (context.intersected()) { 820 if (context.intersected()) {
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
1423 container = this; 1423 container = this;
1424 1424
1425 FloatPoint absPos = container->localToAbsolute(); 1425 FloatPoint absPos = container->localToAbsolute();
1426 region.bounds.setX(absPos.x() + region.bounds.x()); 1426 region.bounds.setX(absPos.x() + region.bounds.x());
1427 region.bounds.setY(absPos.y() + region.bounds.y()); 1427 region.bounds.setY(absPos.y() + region.bounds.y());
1428 1428
1429 regions.append(region); 1429 regions.append(region);
1430 } 1430 }
1431 1431
1432 } // namespace blink 1432 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/InlineFlowBox.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698