Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: Source/core/rendering/RenderInline.cpp

Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 784 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 private: 795 private:
796 bool m_intersected; 796 bool m_intersected;
797 Region& m_region; 797 Region& m_region;
798 const HitTestLocation& m_location; 798 const HitTestLocation& m_location;
799 }; 799 };
800 800
801 } // unnamed namespace 801 } // unnamed namespace
802 802
803 bool RenderInline::hitTestCulledInline(const HitTestRequest& request, HitTestRes ult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accu mulatedOffset) 803 bool RenderInline::hitTestCulledInline(const HitTestRequest& request, HitTestRes ult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accu mulatedOffset)
804 { 804 {
805 ASSERT(result.isRectBasedTest() && !alwaysCreateLineBoxes()); 805 ASSERT(!alwaysCreateLineBoxes());
806 if (!visibleToHitTestRequest(request)) 806 if (!visibleToHitTestRequest(request))
807 return false; 807 return false;
808 808
809 HitTestLocation tmpLocation(locationInContainer, -toLayoutSize(accumulatedOf fset)); 809 HitTestLocation tmpLocation(locationInContainer, -toLayoutSize(accumulatedOf fset));
810 810
811 Region regionResult; 811 Region regionResult;
812 HitTestCulledInlinesGeneratorContext context(regionResult, tmpLocation); 812 HitTestCulledInlinesGeneratorContext context(regionResult, tmpLocation);
813 generateCulledLineBoxRects(context, this); 813 generateCulledLineBoxRects(context, this);
814 814
815 if (context.intersected()) { 815 if (context.intersected()) {
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 container = this; 1405 container = this;
1406 1406
1407 FloatPoint absPos = container->localToAbsolute(); 1407 FloatPoint absPos = container->localToAbsolute();
1408 region.bounds.setX(absPos.x() + region.bounds.x()); 1408 region.bounds.setX(absPos.x() + region.bounds.x());
1409 region.bounds.setY(absPos.y() + region.bounds.y()); 1409 region.bounds.setY(absPos.y() + region.bounds.y());
1410 1410
1411 regions.append(region); 1411 regions.append(region);
1412 } 1412 }
1413 1413
1414 } // namespace blink 1414 } // namespace blink
OLDNEW
« Source/core/rendering/InlineFlowBox.cpp ('K') | « Source/core/rendering/InlineFlowBox.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698