LayoutTests/fast/dom/nodesFromRect/nodesFromRect-culled-inlines-between-silblings.html - Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/nodesFromRect/nodesFromRect-culled-inlines-between-silblings.html

Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/nodesFromRect/nodesFromRect-culled-inline-with-linebreak.html ('k') | LayoutTests/fast/dom/nodesFromRect/nodesFromRect-culled-inlines-between-silblings-expected.txt » ('j') | LayoutTests/fast/events/hit-test-culled_inline.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	pdr. 2014/12/10 07:16:19 This example doesn't seem to work with your patch: This example doesn't seem to work with your patch: http://jsfiddle.net/progers/1pk6tqb8/embedded/result. Do we need more test coverage, or is the example not correct? Miyoung Shin(g) 2014/12/12 14:46:57 I added two kind of tests in this patch. One is t Show quoted text On 2014/12/10 07:16:19, pdr wrote: > This example doesn't seem to work with your patch: > http://jsfiddle.net/progers/1pk6tqb8/embedded/result. Do we need more test > coverage, or is the example not correct? I added two kind of tests in this patch. One is this for hit-test based on rect. Another is hit-test-culled_inline.html for hit-test based on point and it covers your example.
	2 <style type="text/css">

	3 body { font-size: 20px; }

	4 </style>

	5 <div>

	6 <font><a href="#">HIT ME1<br><a href="#" id="test"><b>HIT ME2</b> </a><span ><a href="#">HIT ME3</a></span></font>

	7 </div>

	8 <script src="../../../resources/js-test.js"></script>

	9 <script src="resources/nodesFromRect.js"></script>

	10 <script type="text/javascript">

	11 description('Test to get the node as a result of hit-tests from culled inlin es between siblings');

	12

	13 if (window.internals) {

	14 var test = document.getElementById('test');

	15 checkRect(test.offsetLeft + 4, test.offsetTop - 4, 2, 2, "'HIT ME1'");

	16 checkRect(test.offsetLeft + 4, test.offsetTop + 4, 2, 2, "'HIT ME2'");

	17 checkRect(test.offsetLeft + test.offsetWidth + 4, test.offsetTop + 4, 2, 2, "'HIT ME3'");

	18 }

	19 </script>

OLD	NEW