Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h

Issue 685953002: Add JNI bridges for EnhancedBookmark Create/AddFolder/Move (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
diff --git a/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
index 297cb0cb71b6d2bd3df4880cc0d0d0a46f003d07..c6f2e33f2e1be67d0b3c049c31b0b308232b6b42 100644
--- a/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
+++ b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
@@ -41,11 +41,32 @@ class EnhancedBookmarksBridge : public BookmarkServerServiceObserver {
base::android::ScopedJavaLocalRef<jobjectArray> GetFilters(JNIEnv* env,
jobject obj);
+ base::android::ScopedJavaLocalRef<jobject> AddFolder(JNIEnv* env,
+ jobject obj,
+ jobject j_parent_id_obj,
+ jint index,
+ jstring j_title);
+
+ void MoveBookmark(JNIEnv* env,
+ jobject obj,
+ jobject j_bookmark_id_obj,
+ jobject j_parent_id_obj,
+ jint index);
+
+ base::android::ScopedJavaLocalRef<jobject> AddBookmark(
+ JNIEnv* env,
+ jobject obj,
+ jobject j_parent_id_obj,
+ jint index,
+ jstring j_title,
+ jstring j_url);
// BookmarkServerServiceObserver
// Called on changes to cluster data
virtual void OnChange(BookmarkServerService* service) override;
private:
+ bool IsEditable(const BookmarkNode* node) const;
+
JavaObjectWeakGlobalRef weak_java_ref_;
EnhancedBookmarkModel* enhanced_bookmark_model_;
BookmarkServerClusterService* cluster_service_; // weak

Powered by Google App Engine
This is Rietveld 408576698