Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 685923003: Revert of Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (Closed)

Created:
6 years, 1 month ago by mtklein
Modified:
6 years, 1 month ago
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #1 id:1 of https://codereview.chromium.org/693933004/) Reason for revert: Try again with loops overflow fix landed. Original issue's description: > Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #2 id:20001 of https://codereview.chromium.org/704563003/) > > Reason for revert: > Timing out on nvpr when drawing conics. Fix will take some thought so reverting for now. > > Original issue's description: > > Turn on NVPR 4x MSAA by default when supported in DM and nanobench. > > > > This brings DM and nanobench's default configs in line with GM's. > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739 > > TBR=bsalomon@google.com,mtklein@google.com,mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d5cd4ee5b81b51e43be7ed13f3c0f0f6c1b3fe14 TBR=bsalomon@google.com,mtklein@chromium.org,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2ecf86e55ecb893cf4d04e16a4ac5b0de6dcf173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M dm/DMGpuGMTask.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M dm/DMGpuSupport.h View 2 chunks +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Revert of Turn on NVPR 4x MSAA by default when supported in ...
6 years, 1 month ago (2014-11-06 16:06:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685923003/1
6 years, 1 month ago (2014-11-06 16:06:30 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 16:06:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 2ecf86e55ecb893cf4d04e16a4ac5b0de6dcf173

Powered by Google App Engine
This is Rietveld 408576698