Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 685923002: Support non-integer scroll offsets being passed to the PDF plugin. (Closed)

Created:
6 years, 1 month ago by raymes
Modified:
6 years, 1 month ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support non-integer scroll offsets being passed to the PDF plugin. This broke as a result of non-integer scroll offsets being introduced into blink. BUG=303491 Committed: https://crrev.com/3edd4d5d972d3820ec22cebd011ecbd9d4841143 Cr-Commit-Position: refs/heads/master@{#301765}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M pdf/out_of_process_instance.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M pdf/out_of_process_instance.cc View 1 3 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
raymes
6 years, 1 month ago (2014-10-29 00:09:53 UTC) #2
raymes
PTAL
6 years, 1 month ago (2014-10-29 00:34:41 UTC) #3
Sam McNally
lgtm
6 years, 1 month ago (2014-10-29 00:41:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685923002/20001
6 years, 1 month ago (2014-10-29 00:43:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-29 01:30:10 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 01:30:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3edd4d5d972d3820ec22cebd011ecbd9d4841143
Cr-Commit-Position: refs/heads/master@{#301765}

Powered by Google App Engine
This is Rietveld 408576698