Issue 685803003: Revert of Extend SkFontMgr_Custom to cover ttc, otf, pfb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 685803003: Revert of Extend SkFontMgr_Custom to cover ttc, otf, pfb. (Closed)

Created:
6 years, 1 month ago by bungeman-skia

Modified:
6 years, 1 month ago

Reviewers:
hal.canary, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Extend SkFontMgr_Custom to cover ttc, otf, pfb. (patchset #2 id:20001 of https://codereview.chromium.org/672723002/) Reason for revert: Reverting as this appears to be causing issues with color fonts on Android. Original issue's description: > Extend SkFontMgr_Custom to cover ttc, otf, pfb. > > Adds ability to test ScanFont with Type1 (pfb) fonts > and fonts with multiple faces (ttc). > > Committed: https://skia.googlesource.com/skia/+/ee0c2e4fd429424beaa35f29e7f656997ba3f115 TBR=reed@google.com,halcanary@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/32501a1bd4964576264795ada7e9c3bf572285b3

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -115 lines)			Patch
M	src/fonts/SkFontMgr_fontconfig.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	5 chunks	+15 lines, -47 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType_common.h	View	1 chunk	+2 lines, -11 lines	0 comments	Download
M	src/ports/SkFontHost_linux.cpp	View	5 chunks	+38 lines, -44 lines	0 comments	Download
M	src/ports/SkFontMgr_android.cpp	View	5 chunks	+5 lines, -9 lines	0 comments	Download
M	src/ports/SkFontMgr_fontconfig.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

bungeman-skia

Created Revert of Extend SkFontMgr_Custom to cover ttc, otf, pfb.

6 years, 1 month ago (2014-10-28 19:03:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685803003/1

6 years, 1 month ago (2014-10-28 19:03:45 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-28 19:04:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 32501a1bd4964576264795ada7e9c3bf572285b3