Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 6858005: Compile in support for the Web Audio API on all platforms. It is still (Closed)

Created:
9 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, Chris Rogers
CC:
chromium-reviews, bradnelson, Nicolas Sylvain
Visibility:
Public.

Description

Compile in support for the Web Audio API on all platforms. It is still also controlled by a run-time flag. For the Chromium build, this will currently compile in a stub (no-op) implementation of the FFTFrame class. For Google Chrome branded builds, this will now link against Intel's MKL on Linux and Windows. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/features_override.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
9 years, 8 months ago (2011-04-15 00:04:33 UTC) #1
Chris Rogers
LGTM Awesome - great to see this! I guess the trybots will try the stubs ...
9 years, 8 months ago (2011-04-15 00:17:26 UTC) #2
Lei Zhang
On 2011/04/15 00:17:26, Chris Rogers wrote: > LGTM > > Awesome - great to see ...
9 years, 8 months ago (2011-04-15 23:00:41 UTC) #3
Ken Russell (switch to Gerrit)
9 years, 8 months ago (2011-04-15 23:15:30 UTC) #4
On 2011/04/15 23:00:41, Lei Zhang wrote:
> On 2011/04/15 00:17:26, Chris Rogers wrote:
> > LGTM
> > 
> > Awesome - great to see this!  I guess the trybots will try the stubs
version,
> > but we'll just have to wait and see after landing how the MKL version builds
> for
> > Google branded.
> 
> FYI, this broke the linux official build.

Sorry, I tried my best to test this fully before committing. Fixed upstream in
http://trac.webkit.org/changeset/84046 , next WebKit roll will fix the builder.

Powered by Google App Engine
This is Rietveld 408576698