Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 685783005: Exposing hr tag with SplitterRole. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Exposing hr tag with SplitterRole. This is the third patch in series to remove the redundant role HorizontalRule Role. This CL depends on https://codereview.chromium.org/703033006/ BUG=384723 Committed: https://crrev.com/708102a97f1d000bf29f6bd968940989fcb1ad11 Cr-Commit-Position: refs/heads/master@{#303616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/test/data/accessibility/hr-expected-mac.txt View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
shreeramk
Please review. Thanks!!
6 years, 1 month ago (2014-11-11 04:23:11 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-11 06:34:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685783005/1
6 years, 1 month ago (2014-11-11 08:37:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 09:35:04 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 09:35:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/708102a97f1d000bf29f6bd968940989fcb1ad11
Cr-Commit-Position: refs/heads/master@{#303616}

Powered by Google App Engine
This is Rietveld 408576698