Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/webui/resources/js/cr/ui/focus_grid.js

Issue 685783003: history: fix more focus oddness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/data/webui/history_browsertest.js ('K') | « chrome/test/data/webui/history_browsertest.js ('k') | ui/webui/resources/js/cr/ui/focus_row.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/cr/ui/focus_grid.js
diff --git a/ui/webui/resources/js/cr/ui/focus_grid.js b/ui/webui/resources/js/cr/ui/focus_grid.js
index 862b20aa238d866d7d31a3bd5f65a38a07cb2f3c..2e76ca10c03009f2d5d72e5a781989e1754a00f4 100644
--- a/ui/webui/resources/js/cr/ui/focus_grid.js
+++ b/ui/webui/resources/js/cr/ui/focus_grid.js
@@ -80,7 +80,7 @@ cr.define('cr.ui', function() {
row = this.rows.length - 1;
if (!this.rows[row])
- return;
+ return false;
var colIndex = keyRow.items.indexOf(e.target);
var col = Math.min(colIndex, this.rows[row].items.length - 1);
@@ -88,6 +88,12 @@ cr.define('cr.ui', function() {
this.rows[row].focusIndex(col);
e.preventDefault();
+ return true;
+ },
+
+ /** @override */
+ onMousedown: function(row, e) {
+ return false;
},
/**
« chrome/test/data/webui/history_browsertest.js ('K') | « chrome/test/data/webui/history_browsertest.js ('k') | ui/webui/resources/js/cr/ui/focus_row.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698