history: fix more focus oddness.

chrome/test/data/webui/history_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 GEN('#include "chrome/test/data/webui/history_ui_browsertest.h"');
 
 /** @const */ var TOTAL_RESULT_COUNT = 160;
 /** @const */ var WAIT_TIMEOUT = 200;
 
 /**
@@ skipping 891 matching lines @@
   assertFalse($('history-page').contains(document.activeElement));
 
   waitForCallback('deleteComplete', testDone);
 
   var enter = document.createEvent('KeyboardEvent');
   enter.initKeyboardEvent('keydown', true, true, window, 'Enter');
   document.dispatchEvent(enter);
   assertFalse($('alertOverlay').classList.contains('showing'));
 });
 
+TEST_F('HistoryWebUIRealBackendTest', 'menuButtonActivatesOneRow', function() {
+  var entries = document.querySelectorAll('.entry');
+  assertEquals(3, entries.length);
+  assertTrue(entries[0].classList.contains('active'));
+  assertTrue($('action-menu').hidden);
+
+  // Show the menu via mousedown on the menu button.
+  var menuButton = entries[2].querySelector('.menu-button');
+  menuButton.dispatchEvent(new MouseEvent('mousedown'));
+  expectFalse($('action-menu').hidden);
+
+  // Check that the 'active' item hasn't changed.
+  expectTrue(entries[0].classList.contains('active'));
+  expectFalse(entries[2].classList.contains('active'));
+
+  testDone();
+});
+
+TEST_F('HistoryWebUIRealBackendTest', 'shiftClickActivatesOneRow', function() {
+  var entries = document.querySelectorAll('.entry');
+  assertEquals(3, entries.length);
+  assertTrue(entries[0].classList.contains('active'));
+
+  entries[0].visit.checkBox.focus();
+  assertEquals(entries[0].visit.checkBox, document.activeElement);
+
+  entries[0].visit.checkBox.click();
+  assertTrue(entries[0].visit.checkBox.checked);
+
+  var entryBox = entries[2].querySelector('.entry-box');
+  entryBox.dispatchEvent(new MouseEvent('click', {shiftKey: true}));
+  assertTrue(entries[1].visit.checkBox.checked);
+
+  // Focus shouldn't have changed, but the checkbox should toggle.
+  expectEquals(entries[0].visit.checkBox, document.activeElement);
+
+  expectTrue(entries[0].classList.contains('active'));
+  expectFalse(entries[2].classList.contains('active'));
+
+  var shiftDown = new MouseEvent('mousedown', {shiftKey: true, bubbles: true});
+  entries[2].visit.checkBox.dispatchEvent(shiftDown);
+  expectEquals(entries[2].visit.checkBox, document.activeElement);
+
+  // 'focusin' events aren't dispatched while tests are run in batch (e.g.
+  // --test-launcher-jobs=2). Simulate this. TODO(dbeam): fix instead.

[Dan Beam, 2014/11/04 05:07:10]

if you have anybody that might know why this is, let me know...

[arv (Not doing code reviews), 2014/11/04 15:01:03]

No idea.

+  cr.dispatchSimpleEvent(document.activeElement, 'focusin', true, true);
+
+  expectFalse(entries[0].classList.contains('active'));
+  expectTrue(entries[2].classList.contains('active'));
+
+  testDone();
+});
+
 /**
  * Fixture for History WebUI testing when deletions are prohibited.
  * @extends {HistoryWebUIRealBackendTest}
  * @constructor
  */
 function HistoryWebUIDeleteProhibitedTest() {}
 
 HistoryWebUIDeleteProhibitedTest.prototype = {
   __proto__: HistoryWebUIRealBackendTest.prototype,
 
@@ skipping 133 matching lines @@
 TEST_F('HistoryWebUIWithSchemesTest', 'groupingWithSchemes', function() {
   // Switch to the week view.
   $('timeframe-controls').querySelectorAll('input')[1].click();
   waitForCallback('historyResult', function() {
     // Each URL should be organized under a different "domain".
     expectEquals(document.querySelectorAll('.entry').length, 4);
     expectEquals(document.querySelectorAll('.site-domain-wrapper').length, 4);
     testDone();
   });
 });