history: fix more focus oddness.

history: fix more focus oddness.

Various things (cr.ui.MenuButtons, checkboxes) call .preventDefault()
while handling 'mousedown' events which messes with focus. Account for this.

R=arv@chromium.org
BUG=424475
Committed: https://crrev.com/76cab85264036c5576cbce31ab8dc665591bfc50
Cr-Commit-Position: refs/heads/master@{#302699}

[Dan Beam, 2014-11-04 02:11:57]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2014-11-04 05:07:11]

https://codereview.chromium.org/685783003/diff/40001/chrome/test/data/webui/h...
File chrome/test/data/webui/history_browsertest.js (right):

https://codereview.chromium.org/685783003/diff/40001/chrome/test/data/webui/h...
chrome/test/data/webui/history_browsertest.js:956: // --test-launcher-jobs=2).
Simulate this. TODO(dbeam): fix instead.
if you have anybody that might know why this is, let me know...

[Dan Beam, 2014-11-04 05:09:20]

Patchset #1 (id:20001) has been deleted

[arv (Not doing code reviews), 2014-11-04 15:01:03]

LGTM

https://codereview.chromium.org/685783003/diff/40001/chrome/test/data/webui/h...
File chrome/test/data/webui/history_browsertest.js (right):

https://codereview.chromium.org/685783003/diff/40001/chrome/test/data/webui/h...
chrome/test/data/webui/history_browsertest.js:956: // --test-launcher-jobs=2).
Simulate this. TODO(dbeam): fix instead.
On 2014/11/04 05:07:10, Dan Beam wrote:
> if you have anybody that might know why this is, let me know...

No idea.

https://codereview.chromium.org/685783003/diff/60001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/focus_grid.js (right):

https://codereview.chromium.org/685783003/diff/60001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/focus_grid.js:83: return false;
Instead of relying on return values you could check event.defaultPrevented.

https://codereview.chromium.org/685783003/diff/60001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/focus_row.js (right):

https://codereview.chromium.org/685783003/diff/60001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/focus_row.js:85: * @param {Event} e The mousedown
event.
useless comments are discouraged

[Dan Beam, 2014-11-04 18:00:08]

https://codereview.chromium.org/685783003/diff/60001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/focus_grid.js (right):

https://codereview.chromium.org/685783003/diff/60001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/focus_grid.js:83: return false;
On 2014/11/04 15:01:03, arv wrote:
> Instead of relying on return values you could check event.defaultPrevented.

That's what we were doing, but I don't want to prevent the default in the
mousedown case (as that's what has caused us issues lately), so I wanted the API
to be consistent.

https://codereview.chromium.org/685783003/diff/60001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/focus_row.js (right):

https://codereview.chromium.org/685783003/diff/60001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/focus_row.js:85: * @param {Event} e The mousedown
event.
On 2014/11/04 15:01:03, arv wrote:
> useless comments are discouraged

well, "@param {Event} e" is required so I can shave down to just that, I
guess...

[Dan Beam, 2014-11-04 19:56:54]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-11-04 19:59:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/685783003/80001

[commit-bot: I haz the power, 2014-11-04 21:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-04 21:23:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2014-11-04 21:52:43]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-11-04 21:54:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/685783003/80001

[commit-bot: I haz the power, 2014-11-04 23:08:46]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2014-11-04 23:09:17]

Patchset 3 (id:??) landed as
https://crrev.com/76cab85264036c5576cbce31ab8dc665591bfc50
Cr-Commit-Position: refs/heads/master@{#302699}