Fixed location for debug logs.

Fixed location for debug logs.

Current location is obtained from user prefs.
In addition, s/Value::CreateStringValue/new SringValue/g.

BUG=296501
TEST=manual tests on Falco.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235650

[mmenke, 2013-11-13 22:27:16]

https://codereview.chromium.org/68573005/diff/1/chrome/browser/ui/webui/net_i...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/68573005/diff/1/chrome/browser/ui/webui/net_i...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:1588:
StoreDebugLogs(DownloadPrefs(Profile::FromWebUI(web_ui())).DownloadPath(),
Should we be using
DownloadPrefs:::FromBrowserContext(Profile::FromWebUI(web_ui())), rather than
creating a new download prefs object?

[ygorshenin1, 2013-11-13 23:55:35]

PTAL

https://codereview.chromium.org/68573005/diff/1/chrome/browser/ui/webui/net_i...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/68573005/diff/1/chrome/browser/ui/webui/net_i...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:1588:
StoreDebugLogs(DownloadPrefs(Profile::FromWebUI(web_ui())).DownloadPath(),
On 2013/11/13 22:27:16, mmenke wrote:
> Should we be using
> DownloadPrefs:::FromBrowserContext(Profile::FromWebUI(web_ui())), rather than
> creating a new download prefs object?

Done.

[mmenke, 2013-11-15 04:55:04]

On 2013/11/13 23:55:35, ygorshenin1 wrote:
> PTAL
> 
>
https://codereview.chromium.org/68573005/diff/1/chrome/browser/ui/webui/net_i...
> File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):
> 
>
https://codereview.chromium.org/68573005/diff/1/chrome/browser/ui/webui/net_i...
> chrome/browser/ui/webui/net_internals/net_internals_ui.cc:1588:
> StoreDebugLogs(DownloadPrefs(Profile::FromWebUI(web_ui())).DownloadPath(),
> On 2013/11/13 22:27:16, mmenke wrote:
> > Should we be using
> > DownloadPrefs:::FromBrowserContext(Profile::FromWebUI(web_ui())), rather
than
> > creating a new download prefs object?
> 
> Done.

LGTM

[ygorshenin1, 2013-11-15 04:55:46]

Many thanks!

[commit-bot: I haz the power, 2013-11-15 05:11:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/68573005/50001

[commit-bot: I haz the power, 2013-11-15 07:14:20]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[mmenke, 2013-11-15 15:24:49]

On 2013/11/15 04:55:46, ygorshenin1 wrote:
> Many thanks!

No problem.  Sorry I was so slow with such a small codereview.

[commit-bot: I haz the power, 2013-11-15 15:26:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/68573005/50001

[commit-bot: I haz the power, 2013-11-15 22:11:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/68573005/50001

[commit-bot: I haz the power, 2013-11-16 00:42:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/68573005/50001

[commit-bot: I haz the power, 2013-11-18 07:58:41]

Change committed as 235650