Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: device/battery/battery_status_service_unittest.cc

Issue 685703002: Reland "Replace Chrome IPC with Mojo IPC for querying BatteryStatus service" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Tim's comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/battery/battery_status_service.cc ('k') | device/device_tests.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/battery_status/battery_status_service.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h"
7 #include "base/run_loop.h"
8 #include "device/battery/battery_status_manager.h"
9 #include "device/battery/battery_status_service.h"
10 #include "testing/gtest/include/gtest/gtest.h"
6 11
7 #include "base/bind.h" 12 namespace device {
8 #include "base/run_loop.h"
9 #include "content/browser/battery_status/battery_status_manager.h"
10 #include "content/public/test/test_browser_thread_bundle.h"
11
12 namespace content {
13 13
14 namespace { 14 namespace {
15 15
16 class FakeBatteryManager : public BatteryStatusManager { 16 class FakeBatteryManager : public BatteryStatusManager {
17 public: 17 public:
18 explicit FakeBatteryManager( 18 explicit FakeBatteryManager(
19 const BatteryStatusService::BatteryUpdateCallback& callback) 19 const BatteryStatusService::BatteryUpdateCallback& callback)
20 : callback_(callback), start_invoked_count_(0), stop_invoked_count_(0) {} 20 : callback_(callback), start_invoked_count_(0), stop_invoked_count_(0) {}
21 ~FakeBatteryManager() override {} 21 ~FakeBatteryManager() override {}
22 22
23 // Methods from Battery Status Manager 23 // Methods from Battery Status Manager
24 bool StartListeningBatteryChange() override { 24 bool StartListeningBatteryChange() override {
25 start_invoked_count_++; 25 start_invoked_count_++;
26 return true; 26 return true;
27 } 27 }
28 28
29 void StopListeningBatteryChange() override { stop_invoked_count_++; } 29 void StopListeningBatteryChange() override { stop_invoked_count_++; }
30 30
31 void InvokeUpdateCallback(const blink::WebBatteryStatus& status) { 31 void InvokeUpdateCallback(const BatteryStatus& status) {
32 callback_.Run(status); 32 callback_.Run(status);
33 } 33 }
34 34
35 int start_invoked_count() const { return start_invoked_count_; } 35 int start_invoked_count() const { return start_invoked_count_; }
36 int stop_invoked_count() const { return stop_invoked_count_; } 36 int stop_invoked_count() const { return stop_invoked_count_; }
37 37
38 private: 38 private:
39 BatteryStatusService::BatteryUpdateCallback callback_; 39 BatteryStatusService::BatteryUpdateCallback callback_;
40 int start_invoked_count_; 40 int start_invoked_count_;
41 int stop_invoked_count_; 41 int stop_invoked_count_;
42 42
43 DISALLOW_COPY_AND_ASSIGN(FakeBatteryManager); 43 DISALLOW_COPY_AND_ASSIGN(FakeBatteryManager);
44 }; 44 };
45 45
46 class BatteryStatusServiceTest : public testing::Test { 46 class BatteryStatusServiceTest : public testing::Test {
47 public: 47 public:
48 BatteryStatusServiceTest() 48 BatteryStatusServiceTest()
49 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP), 49 : battery_service_(NULL),
50 battery_service_(0), 50 battery_manager_(NULL),
51 battery_manager_(0),
52 callback1_invoked_count_(0), 51 callback1_invoked_count_(0),
53 callback2_invoked_count_(0) { 52 callback2_invoked_count_(0) {
54 } 53 }
55 virtual ~BatteryStatusServiceTest() { } 54 virtual ~BatteryStatusServiceTest() { }
56 55
57 protected: 56 protected:
58 typedef BatteryStatusService::BatteryUpdateSubscription BatterySubscription; 57 typedef BatteryStatusService::BatteryUpdateSubscription BatterySubscription;
59 58
60 virtual void SetUp() override { 59 virtual void SetUp() override {
61 callback1_ = base::Bind(&BatteryStatusServiceTest::Callback1, 60 callback1_ = base::Bind(&BatteryStatusServiceTest::Callback1,
62 base::Unretained(this)); 61 base::Unretained(this));
63 callback2_ = base::Bind(&BatteryStatusServiceTest::Callback2, 62 callback2_ = base::Bind(&BatteryStatusServiceTest::Callback2,
64 base::Unretained(this)); 63 base::Unretained(this));
65 battery_service_ = BatteryStatusService::GetInstance(); 64 battery_service_ = BatteryStatusService::GetInstance();
66 battery_manager_ = new FakeBatteryManager( 65
67 battery_service_->GetUpdateCallbackForTesting()); 66 // We keep a raw pointer to the FakeBatteryManager, which we expect to
68 battery_service_->SetBatteryManagerForTesting(battery_manager_); 67 // remain valid for the lifetime of the BatteryStatusService.
68 scoped_ptr<FakeBatteryManager> battery_manager(new FakeBatteryManager(
69 battery_service_->GetUpdateCallbackForTesting()));
70 battery_manager_ = battery_manager.get();
71
72 battery_service_->SetBatteryManagerForTesting(battery_manager.Pass());
69 } 73 }
70 74
71 virtual void TearDown() override { 75 virtual void TearDown() override {
72 base::RunLoop().RunUntilIdle(); 76 base::RunLoop().RunUntilIdle();
73 battery_service_->SetBatteryManagerForTesting(0); 77 battery_service_->SetBatteryManagerForTesting(
78 scoped_ptr<BatteryStatusManager>());
74 } 79 }
75 80
76 FakeBatteryManager* battery_manager() { 81 FakeBatteryManager* battery_manager() {
77 return battery_manager_; 82 return battery_manager_;
78 } 83 }
79 84
80 scoped_ptr<BatterySubscription> AddCallback( 85 scoped_ptr<BatterySubscription> AddCallback(
81 const BatteryStatusService::BatteryUpdateCallback& callback) { 86 const BatteryStatusService::BatteryUpdateCallback& callback) {
82 return battery_service_->AddCallback(callback); 87 return battery_service_->AddCallback(callback);
83 } 88 }
84 89
85 int callback1_invoked_count() const { 90 int callback1_invoked_count() const {
86 return callback1_invoked_count_; 91 return callback1_invoked_count_;
87 } 92 }
88 93
89 int callback2_invoked_count() const { 94 int callback2_invoked_count() const {
90 return callback2_invoked_count_; 95 return callback2_invoked_count_;
91 } 96 }
92 97
93 const blink::WebBatteryStatus& battery_status() const { 98 const BatteryStatus& battery_status() const {
94 return battery_status_; 99 return battery_status_;
95 } 100 }
96 101
97 const BatteryStatusService::BatteryUpdateCallback& callback1() const { 102 const BatteryStatusService::BatteryUpdateCallback& callback1() const {
98 return callback1_; 103 return callback1_;
99 } 104 }
100 105
101 const BatteryStatusService::BatteryUpdateCallback& callback2() const { 106 const BatteryStatusService::BatteryUpdateCallback& callback2() const {
102 return callback2_; 107 return callback2_;
103 } 108 }
104 109
105 private: 110 private:
106 void Callback1(const blink::WebBatteryStatus& status) { 111 void Callback1(const BatteryStatus& status) {
107 callback1_invoked_count_++; 112 callback1_invoked_count_++;
108 battery_status_ = status; 113 battery_status_ = status;
109 } 114 }
110 115
111 void Callback2(const blink::WebBatteryStatus& status) { 116 void Callback2(const BatteryStatus& status) {
112 callback2_invoked_count_++; 117 callback2_invoked_count_++;
113 battery_status_ = status; 118 battery_status_ = status;
114 } 119 }
115 120
116 content::TestBrowserThreadBundle thread_bundle_; 121 base::MessageLoop message_loop_;
117 BatteryStatusService* battery_service_; 122 BatteryStatusService* battery_service_;
118 FakeBatteryManager* battery_manager_; 123 FakeBatteryManager* battery_manager_;
119 BatteryStatusService::BatteryUpdateCallback callback1_; 124 BatteryStatusService::BatteryUpdateCallback callback1_;
120 BatteryStatusService::BatteryUpdateCallback callback2_; 125 BatteryStatusService::BatteryUpdateCallback callback2_;
121 int callback1_invoked_count_; 126 int callback1_invoked_count_;
122 int callback2_invoked_count_; 127 int callback2_invoked_count_;
123 blink::WebBatteryStatus battery_status_; 128 BatteryStatus battery_status_;
124 129
125 DISALLOW_COPY_AND_ASSIGN(BatteryStatusServiceTest); 130 DISALLOW_COPY_AND_ASSIGN(BatteryStatusServiceTest);
126 }; 131 };
127 132
128 TEST_F(BatteryStatusServiceTest, AddFirstCallback) { 133 TEST_F(BatteryStatusServiceTest, AddFirstCallback) {
129 scoped_ptr<BatterySubscription> subscription1 = AddCallback(callback1()); 134 scoped_ptr<BatterySubscription> subscription1 = AddCallback(callback1());
130 EXPECT_EQ(1, battery_manager()->start_invoked_count()); 135 EXPECT_EQ(1, battery_manager()->start_invoked_count());
131 EXPECT_EQ(0, battery_manager()->stop_invoked_count()); 136 EXPECT_EQ(0, battery_manager()->stop_invoked_count());
132 subscription1.reset(); 137 subscription1.reset();
133 EXPECT_EQ(1, battery_manager()->start_invoked_count()); 138 EXPECT_EQ(1, battery_manager()->start_invoked_count());
134 EXPECT_EQ(1, battery_manager()->stop_invoked_count()); 139 EXPECT_EQ(1, battery_manager()->stop_invoked_count());
135 } 140 }
136 141
137 TEST_F(BatteryStatusServiceTest, AddCallbackAfterUpdate) { 142 TEST_F(BatteryStatusServiceTest, AddCallbackAfterUpdate) {
138 scoped_ptr<BatterySubscription> subscription1 = AddCallback(callback1()); 143 scoped_ptr<BatterySubscription> subscription1 = AddCallback(callback1());
139 blink::WebBatteryStatus status; 144 BatteryStatus status;
140 battery_manager()->InvokeUpdateCallback(status); 145 battery_manager()->InvokeUpdateCallback(status);
141 base::RunLoop().RunUntilIdle(); 146 base::RunLoop().RunUntilIdle();
142 EXPECT_EQ(1, callback1_invoked_count()); 147 EXPECT_EQ(1, callback1_invoked_count());
143 EXPECT_EQ(0, callback2_invoked_count()); 148 EXPECT_EQ(0, callback2_invoked_count());
144 149
145 scoped_ptr<BatterySubscription> subscription2 = AddCallback(callback2()); 150 scoped_ptr<BatterySubscription> subscription2 = AddCallback(callback2());
146 EXPECT_EQ(1, callback1_invoked_count()); 151 EXPECT_EQ(1, callback1_invoked_count());
147 EXPECT_EQ(1, callback2_invoked_count()); 152 EXPECT_EQ(1, callback2_invoked_count());
148 } 153 }
149 154
150 TEST_F(BatteryStatusServiceTest, TwoCallbacksUpdate) { 155 TEST_F(BatteryStatusServiceTest, TwoCallbacksUpdate) {
151 scoped_ptr<BatterySubscription> subscription1 = AddCallback(callback1()); 156 scoped_ptr<BatterySubscription> subscription1 = AddCallback(callback1());
152 scoped_ptr<BatterySubscription> subscription2 = AddCallback(callback2()); 157 scoped_ptr<BatterySubscription> subscription2 = AddCallback(callback2());
153 158
154 blink::WebBatteryStatus status; 159 BatteryStatus status;
155 status.charging = true; 160 status.charging = true;
156 status.chargingTime = 100; 161 status.charging_time = 100;
157 status.dischargingTime = 200; 162 status.discharging_time = 200;
158 status.level = 0.5; 163 status.level = 0.5;
159 battery_manager()->InvokeUpdateCallback(status); 164 battery_manager()->InvokeUpdateCallback(status);
160 base::RunLoop().RunUntilIdle(); 165 base::RunLoop().RunUntilIdle();
161 166
162 EXPECT_EQ(1, callback1_invoked_count()); 167 EXPECT_EQ(1, callback1_invoked_count());
163 EXPECT_EQ(1, callback2_invoked_count()); 168 EXPECT_EQ(1, callback2_invoked_count());
164 EXPECT_EQ(status.charging, battery_status().charging); 169 EXPECT_EQ(status.charging, battery_status().charging);
165 EXPECT_EQ(status.chargingTime, battery_status().chargingTime); 170 EXPECT_EQ(status.charging_time, battery_status().charging_time);
166 EXPECT_EQ(status.dischargingTime, battery_status().dischargingTime); 171 EXPECT_EQ(status.discharging_time, battery_status().discharging_time);
167 EXPECT_EQ(status.level, battery_status().level); 172 EXPECT_EQ(status.level, battery_status().level);
168 } 173 }
169 174
170 TEST_F(BatteryStatusServiceTest, RemoveOneCallback) { 175 TEST_F(BatteryStatusServiceTest, RemoveOneCallback) {
171 scoped_ptr<BatterySubscription> subscription1 = AddCallback(callback1()); 176 scoped_ptr<BatterySubscription> subscription1 = AddCallback(callback1());
172 scoped_ptr<BatterySubscription> subscription2 = AddCallback(callback2()); 177 scoped_ptr<BatterySubscription> subscription2 = AddCallback(callback2());
173 178
174 blink::WebBatteryStatus status; 179 BatteryStatus status;
175 battery_manager()->InvokeUpdateCallback(status); 180 battery_manager()->InvokeUpdateCallback(status);
176 base::RunLoop().RunUntilIdle(); 181 base::RunLoop().RunUntilIdle();
177 EXPECT_EQ(1, callback1_invoked_count()); 182 EXPECT_EQ(1, callback1_invoked_count());
178 EXPECT_EQ(1, callback2_invoked_count()); 183 EXPECT_EQ(1, callback2_invoked_count());
179 184
180 subscription1.reset(); 185 subscription1.reset();
181 battery_manager()->InvokeUpdateCallback(status); 186 battery_manager()->InvokeUpdateCallback(status);
182 base::RunLoop().RunUntilIdle(); 187 base::RunLoop().RunUntilIdle();
183 EXPECT_EQ(1, callback1_invoked_count()); 188 EXPECT_EQ(1, callback1_invoked_count());
184 EXPECT_EQ(2, callback2_invoked_count()); 189 EXPECT_EQ(2, callback2_invoked_count());
185 } 190 }
186 191
187 } // namespace 192 } // namespace
188 193
189 } // namespace content 194 } // namespace device
OLDNEW
« no previous file with comments | « device/battery/battery_status_service.cc ('k') | device/device_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698