Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 685653002: [vim] Check output_dir in ninja-build.vim. (Closed)

Created:
6 years, 1 month ago by please use gerrit instead
Modified:
6 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[vim] Check output_dir in ninja-build.vim. This patch changes ninja-build.vim to check GYP_GENERATOR_FLAGS for output_dir setting. The function to check the output directory is shared between YouCompleteMe configuration and ninja-build.vim. BUG=NONE Committed: https://crrev.com/d026bc969fce5167b30df795bd4bba4df2a282ee Cr-Commit-Position: refs/heads/master@{#301871}

Patch Set 1 #

Patch Set 2 : Simpler ycm config. #

Patch Set 3 : Pass configuration to GetNinjaOutputDirectory(). #

Patch Set 4 : Tweak similarity. #

Patch Set 5 : Add line for style consistency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -255 lines) Patch
M tools/vim/chromium.ycm_extra_conf.py View 1 3 chunks +3 lines, -34 lines 0 comments Download
M tools/vim/ninja-build.vim View 1 2 2 chunks +9 lines, -23 lines 0 comments Download
A + tools/vim/ninja_output.py View 1 2 3 4 3 chunks +8 lines, -198 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
please use gerrit instead
thakis@, PTAL Patch Set 5.
6 years, 1 month ago (2014-10-28 03:46:54 UTC) #3
please use gerrit instead
Nico: ping...
6 years, 1 month ago (2014-10-29 16:24:11 UTC) #4
Nico
Sorry, missed this yesterday. Can you use ninja_build = __import__("ninja-build") in the ycm file, so ...
6 years, 1 month ago (2014-10-29 16:46:45 UTC) #5
Nico
lgtm Sorry, I missed that you're extracting this code from a .vim file, not a ...
6 years, 1 month ago (2014-10-29 17:01:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685653002/90001
6 years, 1 month ago (2014-10-29 17:04:50 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:90001)
6 years, 1 month ago (2014-10-29 17:54:11 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 17:54:49 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d026bc969fce5167b30df795bd4bba4df2a282ee
Cr-Commit-Position: refs/heads/master@{#301871}

Powered by Google App Engine
This is Rietveld 408576698