Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: Source/bindings/v8/custom/V8SVGLengthCustom.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8SVGLengthCustom.cpp
diff --git a/Source/bindings/v8/custom/V8SVGLengthCustom.cpp b/Source/bindings/v8/custom/V8SVGLengthCustom.cpp
index 2bccab5d9a3ad3b91f3dce9f87d9031078ff7a1a..94a7948be933c1760b5e4234722bf5edf00805ac 100644
--- a/Source/bindings/v8/custom/V8SVGLengthCustom.cpp
+++ b/Source/bindings/v8/custom/V8SVGLengthCustom.cpp
@@ -44,7 +44,7 @@ void V8SVGLength::valueAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::
{
SVGPropertyTearOff<SVGLength>* wrapper = V8SVGLength::toNative(info.Holder());
SVGLength& imp = wrapper->propertyReference();
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
SVGLengthContext lengthContext(wrapper->contextElement());
float value = imp.value(lengthContext, exceptionState);
if (exceptionState.throwIfNeeded())
@@ -66,7 +66,7 @@ void V8SVGLength::valueAttributeSetterCustom(v8::Local<v8::Value> value, const v
}
SVGLength& imp = wrapper->propertyReference();
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
SVGLengthContext lengthContext(wrapper->contextElement());
imp.setValue(static_cast<float>(value->NumberValue()), lengthContext, exceptionState);
if (exceptionState.throwIfNeeded())
@@ -88,7 +88,7 @@ void V8SVGLength::convertToSpecifiedUnitsMethodCustom(const v8::FunctionCallback
}
SVGLength& imp = wrapper->propertyReference();
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
V8TRYCATCH_VOID(int, unitType, toUInt32(info[0]));
SVGLengthContext lengthContext(wrapper->contextElement());
imp.convertToSpecifiedUnits(unitType, lengthContext, exceptionState);
« no previous file with comments | « Source/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698