Source/bindings/v8/custom/V8NodeCustom.cpp - Issue 68563003: Create DOM exceptions in the correct context.

Unified Diff: Source/bindings/v8/custom/V8NodeCustom.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8NodeCustom.cpp

diff --git a/Source/bindings/v8/custom/V8NodeCustom.cpp b/Source/bindings/v8/custom/V8NodeCustom.cpp

index 76b3e67a201be36bb7bb58e2d2d3dc00453f6794..999498d3b505b8bb85ad5a36e47e6e7496820d65 100644

--- a/Source/bindings/v8/custom/V8NodeCustom.cpp

+++ b/Source/bindings/v8/custom/V8NodeCustom.cpp

@@ -66,7 +66,7 @@ void V8Node::insertBeforeMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

- ExceptionState exceptionState(info.GetIsolate());

+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());

Node* newChild = V8Node::hasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;

Node* refChild = V8Node::hasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0;

imp->insertBefore(newChild, refChild, exceptionState);

@@ -82,7 +82,7 @@ void V8Node::replaceChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

- ExceptionState exceptionState(info.GetIsolate());

+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());

Node* newChild = V8Node::hasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;

Node* oldChild = V8Node::hasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0;

imp->replaceChild(newChild, oldChild, exceptionState);

@@ -98,7 +98,7 @@ void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

- ExceptionState exceptionState(info.GetIsolate());

+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());

Node* oldChild = V8Node::hasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;

imp->removeChild(oldChild, exceptionState);

if (exceptionState.throwIfNeeded())

@@ -113,7 +113,7 @@ void V8Node::appendChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

- ExceptionState exceptionState(info.GetIsolate());

+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());

Node* newChild = V8Node::hasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;

imp->appendChild(newChild, exceptionState);

if (exceptionState.throwIfNeeded())

« no previous file with comments | « Source/bindings/v8/custom/V8MessagePortCustom.cpp ('k') | Source/bindings/v8/custom/V8SQLTransactionCustom.cpp » ('j') | no next file with comments »