Source/bindings/v8/ExceptionStatePlaceholder.h - Issue 68563003: Create DOM exceptions in the correct context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ExceptionStatePlaceholder.h

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ExceptionStatePlaceholder.h

diff --git a/Source/bindings/v8/ExceptionStatePlaceholder.h b/Source/bindings/v8/ExceptionStatePlaceholder.h

index b69a6c507e1e2a7fd414dfa08967afedc170647d..84f6eb0b0f621d6a57d64597fa52deb0471e0b3d 100644

--- a/Source/bindings/v8/ExceptionStatePlaceholder.h

+++ b/Source/bindings/v8/ExceptionStatePlaceholder.h

@@ -43,7 +43,7 @@ typedef int ExceptionCode;

class IgnorableExceptionState : public ExceptionState {

public:

- IgnorableExceptionState(): ExceptionState(0) { }

+ IgnorableExceptionState(): ExceptionState(v8::Handle<v8::Object>(), 0) { }

ExceptionState& returnThis() { return *this; }

virtual void throwDOMException(const ExceptionCode&, const String& message = String()) OVERRIDE FINAL { };

virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL { }