Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: Source/bindings/tests/results/V8TestTypedefs.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestTypedefs.cpp
diff --git a/Source/bindings/tests/results/V8TestTypedefs.cpp b/Source/bindings/tests/results/V8TestTypedefs.cpp
index 2dec4f233c5e244cbedc394398c691eae94d7627..9ae35dafcafd138e7a5875e969090f18efa0e22f 100644
--- a/Source/bindings/tests/results/V8TestTypedefs.cpp
+++ b/Source/bindings/tests/results/V8TestTypedefs.cpp
@@ -137,7 +137,7 @@ static void immutableSerializedScriptValueAttributeSetterCallback(v8::Local<v8::
static void attrWithGetterExceptionAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
int jsValue = imp->attrWithGetterException(exceptionState);
if (UNLIKELY(exceptionState.throwIfNeeded()))
return;
@@ -182,7 +182,7 @@ static void attrWithSetterExceptionAttributeSetter(v8::Local<v8::Value> jsValue,
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
V8TRYCATCH_VOID(int, cppValue, toInt32(jsValue));
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
imp->setAttrWithSetterException(cppValue, exceptionState);
exceptionState.throwIfNeeded();
}
@@ -197,7 +197,7 @@ static void attrWithSetterExceptionAttributeSetterCallback(v8::Local<v8::String>
static void stringAttrWithGetterExceptionAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
String jsValue = imp->stringAttrWithGetterException(exceptionState);
if (UNLIKELY(exceptionState.throwIfNeeded()))
return;
@@ -242,7 +242,7 @@ static void stringAttrWithSetterExceptionAttributeSetter(v8::Local<v8::Value> js
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue, jsValue);
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
imp->setStringAttrWithSetterException(cppValue, exceptionState);
exceptionState.throwIfNeeded();
}
@@ -408,7 +408,7 @@ static void stringArrayFunctionMethod(const v8::FunctionCallbackInfo<v8::Value>&
return;
}
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(info[0], 1, info.GetIsolate()));
Vector<String> result = imp->stringArrayFunction(values, exceptionState);
if (exceptionState.throwIfNeeded())
@@ -430,7 +430,7 @@ static void stringArrayFunction2Method(const v8::FunctionCallbackInfo<v8::Value>
return;
}
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(info[0], 1, info.GetIsolate()));
Vector<String> result = imp->stringArrayFunction2(values, exceptionState);
if (exceptionState.throwIfNeeded())
@@ -448,7 +448,7 @@ static void stringArrayFunction2MethodCallback(const v8::FunctionCallbackInfo<v8
static void methodWithExceptionMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
imp->methodWithException(exceptionState);
if (exceptionState.throwIfNeeded())
return;
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/v8/CustomElementConstructorBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698