Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: Source/bindings/tests/results/V8TestObjectPython.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/tests/results/V8TestTypedefs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestObjectPython.cpp
diff --git a/Source/bindings/tests/results/V8TestObjectPython.cpp b/Source/bindings/tests/results/V8TestObjectPython.cpp
index 8ded97b70ca45b40d5adc0d148bf1d07dd8168b6..5ab000431d674161b538d3005f203a9a268f247e 100644
--- a/Source/bindings/tests/results/V8TestObjectPython.cpp
+++ b/Source/bindings/tests/results/V8TestObjectPython.cpp
@@ -1555,7 +1555,7 @@ static void callWithExecutionContextAnyAttributeAttributeSetterCallback(v8::Loca
static void checkSecurityForNodeReadonlyDocumentAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
if (!BindingSecurity::shouldAllowAccessToNode(imp->checkSecurityForNodeReadonlyDocumentAttribute(), exceptionState)) {
v8SetReturnValueNull(info);
exceptionState.throwIfNeeded();
@@ -1915,7 +1915,7 @@ static void enforceRangeLongAttributeAttributeSetterCallback(v8::Local<v8::Strin
static void getterRaisesExceptionLongAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
int jsValue = imp->getterRaisesExceptionLongAttribute(exceptionState);
if (UNLIKELY(exceptionState.throwIfNeeded()))
return;
@@ -2440,7 +2440,7 @@ static void activityLoggingGetterForIsolatedWorldsPerWorldBindingsLongAttributeA
static void raisesExceptionLongAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
int jsValue = imp->raisesExceptionLongAttribute(exceptionState);
if (UNLIKELY(exceptionState.throwIfNeeded()))
return;
@@ -2458,7 +2458,7 @@ static void raisesExceptionLongAttributeAttributeSetter(v8::Local<v8::Value> jsV
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
V8TRYCATCH_VOID(int, cppValue, toInt32(jsValue));
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
imp->setRaisesExceptionLongAttribute(cppValue, exceptionState);
exceptionState.throwIfNeeded();
}
@@ -2937,7 +2937,7 @@ static void setterRaisesExceptionLongAttributeAttributeSetter(v8::Local<v8::Valu
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
V8TRYCATCH_VOID(int, cppValue, toInt32(jsValue));
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
imp->setSetterRaisesExceptionLongAttribute(cppValue, exceptionState);
exceptionState.throwIfNeeded();
}
@@ -5196,7 +5196,7 @@ static void addEventListenerMethod(const v8::FunctionCallbackInfo<v8::Value>& in
{
EventTarget* impl = V8TestObjectPython::toNative(info.Holder());
if (DOMWindow* window = impl->toDOMWindow()) {
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
if (!BindingSecurity::shouldAllowAccessToFrame(window->frame(), exceptionState)) {
exceptionState.throwIfNeeded();
return;
@@ -5224,7 +5224,7 @@ static void removeEventListenerMethod(const v8::FunctionCallbackInfo<v8::Value>&
{
EventTarget* impl = V8TestObjectPython::toNative(info.Holder());
if (DOMWindow* window = impl->toDOMWindow()) {
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
if (!BindingSecurity::shouldAllowAccessToFrame(window->frame(), exceptionState)) {
exceptionState.throwIfNeeded();
return;
@@ -5903,7 +5903,7 @@ static void perWorldBindingsVoidMethodTestInterfaceEmptyArgMethodCallbackForMain
static void raisesExceptionVoidMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
imp->raisesExceptionVoidMethod(exceptionState);
if (exceptionState.throwIfNeeded())
return;
@@ -5919,7 +5919,7 @@ static void raisesExceptionVoidMethodMethodCallback(const v8::FunctionCallbackIn
static void raisesExceptionVoidMethodOptionalLongArgMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
if (UNLIKELY(info.Length() <= 0)) {
imp->raisesExceptionVoidMethodOptionalLongArg(exceptionState);
if (exceptionState.throwIfNeeded())
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/tests/results/V8TestTypedefs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698