Source/bindings/tests/results/V8TestNode.cpp - Issue 68563003: Create DOM exceptions in the correct context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestNode.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestNode.cpp

diff --git a/Source/bindings/tests/results/V8TestNode.cpp b/Source/bindings/tests/results/V8TestNode.cpp

index cbd66fc4a7e25e0e08d2fc5b567de21729fa238e..85e83a83d749ed9c5029e40e4886a333a172ad55 100644

--- a/Source/bindings/tests/results/V8TestNode.cpp

+++ b/Source/bindings/tests/results/V8TestNode.cpp

@@ -119,7 +119,7 @@ static void hrefThrowsAttributeSetter(v8::Local<v8::Value> jsValue, const v8::Pr

{

TestNode* imp = V8TestNode::toNative(info.Holder());

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue, jsValue);

- ExceptionState exceptionState(info.GetIsolate());

+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());

imp->setHrefThrows(cppValue, exceptionState);

exceptionState.throwIfNeeded();

}