Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp
index 4ab90c333a32c352fd6b7b5814cf2b6078841593..06c11ab833c819bc28a264ab09d4ae3b23600011 100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -150,7 +150,7 @@ static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> j
static void indexedPropertyDeleter(unsigned index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
TestEventTarget* collection = V8TestEventTarget::toNative(info.Holder());
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
bool result = collection->anonymousIndexedDeleter(index, exceptionState);
if (exceptionState.throwIfNeeded())
return;
@@ -234,7 +234,7 @@ static void namedPropertyDeleterCallback(v8::Local<v8::String> name, const v8::P
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
TestEventTarget* collection = V8TestEventTarget::toNative(info.Holder());
Vector<String> names;
collection->namedPropertyEnumerator(names, exceptionState);
@@ -250,7 +250,7 @@ static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCal
{
TestEventTarget* collection = V8TestEventTarget::toNative(info.Holder());
AtomicString propertyName = toWebCoreAtomicString(name);
- ExceptionState exceptionState(info.GetIsolate());
+ ExceptionState exceptionState(info.Holder(), info.GetIsolate());
bool result = collection->namedPropertyQuery(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
« no previous file with comments | « Source/bindings/tests/results/V8TestActiveDOMObject.cpp ('k') | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698