Source/bindings/v8/custom/V8NodeCustom.cpp - Issue 68563003: Create DOM exceptions in the correct context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8NodeCustom.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/V8ThrowException.h ('K') | « Source/bindings/v8/custom/V8MessagePortCustom.cpp ('k') | Source/bindings/v8/custom/V8SQLTransactionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8NodeCustom.cpp

diff --git a/Source/bindings/v8/custom/V8NodeCustom.cpp b/Source/bindings/v8/custom/V8NodeCustom.cpp

index c246d839d0907e4efab9915a6301a9b600299240..839e772ce571c9449ff616f58ad58c0de376bf2e 100644

--- a/Source/bindings/v8/custom/V8NodeCustom.cpp

+++ b/Source/bindings/v8/custom/V8NodeCustom.cpp

@@ -66,7 +66,7 @@ void V8Node::insertBeforeMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

- ExceptionState es(info.GetIsolate());

+ ExceptionState es(info.Holder(), info.GetIsolate());

Node* newChild = V8Node::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;

Node* refChild = V8Node::HasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0;

imp->insertBefore(newChild, refChild, es);

@@ -82,7 +82,7 @@ void V8Node::replaceChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

- ExceptionState es(info.GetIsolate());

+ ExceptionState es(info.Holder(), info.GetIsolate());

Node* newChild = V8Node::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;

Node* oldChild = V8Node::HasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0;

imp->replaceChild(newChild, oldChild, es);

@@ -98,7 +98,7 @@ void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

- ExceptionState es(info.GetIsolate());

+ ExceptionState es(info.Holder(), info.GetIsolate());

Node* oldChild = V8Node::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;

imp->removeChild(oldChild, es);

if (es.throwIfNeeded())

@@ -113,7 +113,7 @@ void V8Node::appendChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

- ExceptionState es(info.GetIsolate());

+ ExceptionState es(info.Holder(), info.GetIsolate());

Node* newChild = V8Node::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;

imp->appendChild(newChild, es);

if (es.throwIfNeeded())