Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp - Issue 68563003: Create DOM exceptions in the correct context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/V8ThrowException.h ('K') | « Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

index 7acc533f2a0c04dcf15c15f5cbfd61a4c3b8188f..ef96becb2073c493755d1bd4b09480a32060b21d 100644

--- a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

@@ -47,7 +47,7 @@ void V8HTMLFrameElement::locationAttributeSetterCustom(v8::Local<v8::Value> valu

HTMLFrameElement* frame = V8HTMLFrameElement::toNative(info.Holder());

String locationValue = toWebCoreStringWithNullCheck(value);

- ExceptionState es(info.GetIsolate());

+ ExceptionState es(info.Holder(), info.GetIsolate());

if (protocolIsJavaScript(stripLeadingAndTrailingHTMLSpaces(locationValue)) && !BindingSecurity::shouldAllowAccessToFrame(frame->contentFrame(), es)) {

es.throwIfNeeded();

return;