Source/bindings/v8/custom/V8DocumentCustom.cpp - Issue 68563003: Create DOM exceptions in the correct context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8DocumentCustom.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8DocumentCustom.cpp

diff --git a/Source/bindings/v8/custom/V8DocumentCustom.cpp b/Source/bindings/v8/custom/V8DocumentCustom.cpp

index d3da93ea99e7b954ff6081ea083efde70dad5ac0..217e515684b70185c191616133dc81f71bc2f0d2 100644

--- a/Source/bindings/v8/custom/V8DocumentCustom.cpp

+++ b/Source/bindings/v8/custom/V8DocumentCustom.cpp

@@ -60,7 +60,7 @@ namespace WebCore {

void V8Document::evaluateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

RefPtr<Document> document = V8Document::toNative(info.Holder());

- ExceptionState es(info.GetIsolate());

+ ExceptionState es(info.Holder(), info.GetIsolate());

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, expression, info[0]);

RefPtr<Node> contextNode;

if (V8Node::HasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())))