Source/bindings/v8/V8Initializer.cpp - Issue 68563003: Create DOM exceptions in the correct context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Initializer.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8Initializer.cpp

diff --git a/Source/bindings/v8/V8Initializer.cpp b/Source/bindings/v8/V8Initializer.cpp

index 73283dba0e16fc569d80d6cc8b6bcbef329a74c3..e354b4115bcc185fc22272cb93e11f196613994a 100644

--- a/Source/bindings/v8/V8Initializer.cpp

+++ b/Source/bindings/v8/V8Initializer.cpp

@@ -135,7 +135,7 @@ static void failedAccessCheckCallbackInMainThread(v8::Local<v8::Object> host, v8

return;

DOMWindow* targetWindow = target->domWindow();

- ExceptionState es(v8::Isolate::GetCurrent());

+ ExceptionState es(v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());

es.throwSecurityError(targetWindow->sanitizedCrossDomainAccessErrorMessage(activeDOMWindow()), targetWindow->crossDomainAccessErrorMessage(activeDOMWindow()));

es.throwIfNeeded();

}

« no previous file with comments | « Source/bindings/v8/V8Binding.cpp ('k') | Source/bindings/v8/V8ThrowException.h » ('j') | Source/bindings/v8/V8ThrowException.h » ('J')