Source/bindings/v8/CustomElementConstructorBuilder.cpp - Issue 68563003: Create DOM exceptions in the correct context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CustomElementConstructorBuilder.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/CustomElementConstructorBuilder.cpp

diff --git a/Source/bindings/v8/CustomElementConstructorBuilder.cpp b/Source/bindings/v8/CustomElementConstructorBuilder.cpp

index be454958d1b7ae515131b05e123c9aacdc1694bf..cea73348c74b70c4c033871f6790a49f0a0a8bd4 100644

--- a/Source/bindings/v8/CustomElementConstructorBuilder.cpp

+++ b/Source/bindings/v8/CustomElementConstructorBuilder.cpp

@@ -272,7 +272,7 @@ static void constructCustomElement(const v8::FunctionCallbackInfo<v8::Value>& in

v8::Handle<v8::Value> maybeType = info.Callee()->GetHiddenValue(V8HiddenPropertyName::customElementType(isolate));

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, type, maybeType);

- ExceptionState es(info.GetIsolate());

+ ExceptionState es(info.Holder(), info.GetIsolate());

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

RefPtr<Element> element = document->createElementNS(namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type, es);

if (es.throwIfNeeded())