Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: Source/bindings/tests/results/V8TestObjectPython.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObjectPython.cpp
diff --git a/Source/bindings/tests/results/V8TestObjectPython.cpp b/Source/bindings/tests/results/V8TestObjectPython.cpp
index ac1416782104b39132a96e82f7356e99e1e32f15..f664b5c5a297213d1fcebb77e03ced75e7a67d0e 100644
--- a/Source/bindings/tests/results/V8TestObjectPython.cpp
+++ b/Source/bindings/tests/results/V8TestObjectPython.cpp
@@ -1554,7 +1554,7 @@ static void callWithExecutionContextAnyAttributeAttributeSetterCallback(v8::Loca
static void checkSecurityForNodeReadonlyDocumentAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
if (!BindingSecurity::shouldAllowAccessToNode(imp->checkSecurityForNodeReadonlyDocumentAttribute(), es)) {
v8SetReturnValueNull(info);
es.throwIfNeeded();
@@ -1914,7 +1914,7 @@ static void enforceRangeLongAttributeAttributeSetterCallback(v8::Local<v8::Strin
static void getterRaisesExceptionLongAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
int jsValue = imp->getterRaisesExceptionLongAttribute(es);
if (UNLIKELY(es.throwIfNeeded()))
return;
@@ -2439,7 +2439,7 @@ static void activityLoggingGetterForIsolatedWorldsPerWorldBindingsLongAttributeA
static void raisesExceptionLongAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
int jsValue = imp->raisesExceptionLongAttribute(es);
if (UNLIKELY(es.throwIfNeeded()))
return;
@@ -2457,7 +2457,7 @@ static void raisesExceptionLongAttributeAttributeSetter(v8::Local<v8::Value> jsV
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
V8TRYCATCH_VOID(int, cppValue, toInt32(jsValue));
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
imp->setRaisesExceptionLongAttribute(cppValue, es);
es.throwIfNeeded();
}
@@ -2936,7 +2936,7 @@ static void setterRaisesExceptionLongAttributeAttributeSetter(v8::Local<v8::Valu
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
V8TRYCATCH_VOID(int, cppValue, toInt32(jsValue));
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
imp->setSetterRaisesExceptionLongAttribute(cppValue, es);
es.throwIfNeeded();
}
@@ -5407,7 +5407,7 @@ static void perWorldBindingsVoidMethodTestInterfaceEmptyArgMethodCallbackForMain
static void raisesExceptionVoidMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
imp->raisesExceptionVoidMethod(es);
if (es.throwIfNeeded())
return;
@@ -5423,7 +5423,7 @@ static void raisesExceptionVoidMethodMethodCallback(const v8::FunctionCallbackIn
static void raisesExceptionVoidMethodOptionalLongArgMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
if (UNLIKELY(info.Length() <= 0)) {
imp->raisesExceptionVoidMethodOptionalLongArg(es);
if (es.throwIfNeeded())

Powered by Google App Engine
This is Rietveld 408576698