Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp
index 144a0a94b310279c1fdceb206173d8f276b0d97b..8c294c4b39bbf35c87ec575fe5b54674df568000 100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -150,7 +150,7 @@ static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> j
static void indexedPropertyDeleter(unsigned index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
TestEventTarget* collection = V8TestEventTarget::toNative(info.Holder());
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
bool result = collection->anonymousIndexedDeleter(index, es);
if (es.throwIfNeeded())
return;
@@ -234,7 +234,7 @@ static void namedPropertyDeleterCallback(v8::Local<v8::String> name, const v8::P
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
TestEventTarget* collection = V8TestEventTarget::toNative(info.Holder());
Vector<String> names;
collection->namedPropertyEnumerator(names, es);
@@ -250,7 +250,7 @@ static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCal
{
TestEventTarget* collection = V8TestEventTarget::toNative(info.Holder());
AtomicString propertyName = toWebCoreAtomicString(name);
- ExceptionState es(info.GetIsolate());
+ ExceptionState es(info.Holder(), info.GetIsolate());
bool result = collection->namedPropertyQuery(propertyName, es);
if (es.throwIfNeeded())
return;

Powered by Google App Engine
This is Rietveld 408576698