Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: Source/bindings/v8/custom/V8SQLTransactionCustom.cpp

Issue 68563003: Create DOM exceptions in the correct context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased onto df9a982fbe97 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 RefPtr<SQLStatementErrorCallback> errorCallback; 102 RefPtr<SQLStatementErrorCallback> errorCallback;
103 if (info.Length() > 3 && !isUndefinedOrNull(info[3])) { 103 if (info.Length() > 3 && !isUndefinedOrNull(info[3])) {
104 if (!info[3]->IsObject()) { 104 if (!info[3]->IsObject()) {
105 setDOMException(TypeMismatchError, info.GetIsolate()); 105 setDOMException(TypeMismatchError, info.GetIsolate());
106 return; 106 return;
107 } 107 }
108 errorCallback = V8SQLStatementErrorCallback::create(info[3], executionCo ntext); 108 errorCallback = V8SQLStatementErrorCallback::create(info[3], executionCo ntext);
109 } 109 }
110 110
111 ExceptionState exceptionState(info.GetIsolate()); 111 ExceptionState exceptionState(info.Holder(), info.GetIsolate());
112 transaction->executeSQL(statement, sqlValues, callback, errorCallback, excep tionState); 112 transaction->executeSQL(statement, sqlValues, callback, errorCallback, excep tionState);
113 exceptionState.throwIfNeeded(); 113 exceptionState.throwIfNeeded();
114 } 114 }
115 115
116 } // namespace WebCore 116 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8NodeCustom.cpp ('k') | Source/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698